Re: [PATCH v2] hw/core/loader: allow loading larger ROMs

2024-06-28 Thread Daniel P . Berrangé
On Thu, Jun 27, 2024 at 05:58:17PM -0700, Gregor Haas wrote: > The read() syscall is not guaranteed to return all data from a file. The > default ROM loader implementation currently does not take this into account, > instead failing if all bytes are not read at once. This change loads the ROM > usi

RE: [PATCH v2] hw/core/loader: allow loading larger ROMs

2024-06-27 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Gregor Haas > Sent: Friday, June 28, 2024 8:58 AM > To: qemu-devel@nongnu.org > Cc: Yao, Xingtao/姚 幸涛 ; Gregor Haas > > Subject: [PATCH v2] hw/core/loader: allow loading larger ROMs > > The read() syscall is not guaranteed to

[PATCH v2] hw/core/loader: allow loading larger ROMs

2024-06-27 Thread Gregor Haas
The read() syscall is not guaranteed to return all data from a file. The default ROM loader implementation currently does not take this into account, instead failing if all bytes are not read at once. This change loads the ROM using load_image_size() instead, which correctly reads all data using mu