Re: [PATCH v2] hw/acpi: Add vmclock device

2024-08-01 Thread David Woodhouse
On Thu, 2024-08-01 at 05:48 -0400, Michael S. Tsirkin wrote: > On Thu, Aug 01, 2024 at 09:49:06AM +0100, David Woodhouse wrote: > > On Wed, 2024-07-31 at 17:19 -0400, Michael S. Tsirkin wrote: > > > > > > > Perfect. So as and when the header is in its final form in Linux, > > > > it can be part of

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 09:49:06AM +0100, David Woodhouse wrote: > On Wed, 2024-07-31 at 17:19 -0400, Michael S. Tsirkin wrote: > > > > > Perfect. So as and when the header is in its final form in Linux, > > > it can be part of the automated import and we'll use that version. > > > At that point w

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-08-01 Thread David Woodhouse
On Wed, 2024-07-31 at 17:19 -0400, Michael S. Tsirkin wrote: > > > Perfect. So as and when the header is in its final form in Linux, > > it can be part of the automated import and we'll use that version. > > At that point we can drop the one that's sitting alongside the > > device itself in hw/acp

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-07-31 Thread Michael S. Tsirkin
On Wed, Jul 31, 2024 at 01:23:49AM +0100, David Woodhouse wrote: > On 30 July 2024 21:45:53 BST, "Michael S. Tsirkin" wrote: > >On Tue, Jul 30, 2024 at 08:04:17PM +0100, David Woodhouse wrote: > >> On 30 July 2024 18:53:18 BST, "Michael S. Tsirkin" wrote: > >> >We don't want to manually sync head

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-07-30 Thread David Woodhouse
On 30 July 2024 21:45:53 BST, "Michael S. Tsirkin" wrote: >On Tue, Jul 30, 2024 at 08:04:17PM +0100, David Woodhouse wrote: >> On 30 July 2024 18:53:18 BST, "Michael S. Tsirkin" wrote: >> >We don't want to manually sync headers with Linux. >> >> Indeed. I was briefly tempted to fake it, but figu

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2024 at 08:04:17PM +0100, David Woodhouse wrote: > On 30 July 2024 18:53:18 BST, "Michael S. Tsirkin" wrote: > >We don't want to manually sync headers with Linux. > > Indeed. I was briefly tempted to fake it, but figured it might get lost if we > subsequently do run the script to

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-07-30 Thread David Woodhouse
On 30 July 2024 18:53:18 BST, "Michael S. Tsirkin" wrote: >We don't want to manually sync headers with Linux. Indeed. I was briefly tempted to fake it, but figured it might get lost if we subsequently do run the script to automatically merge from Linux, before the guest driver is merged there.

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-07-30 Thread Michael S. Tsirkin
> diff --git a/hw/acpi/vmclock-abi.h b/hw/acpi/vmclock-abi.h > new file mode 100644 > index 00..19cbf85efd > --- /dev/null > +++ b/hw/acpi/vmclock-abi.h > @@ -0,0 +1,186 @@ > +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR > BSD-2-Clause) */ > + > +/* > + * This structur

[PATCH v2] hw/acpi: Add vmclock device

2024-07-30 Thread David Woodhouse
From: David Woodhouse The vmclock device addresses the problem of live migration with precision clocks. The tolerances of a hardware counter (e.g. TSC) are typically around ±50PPM. A guest will use NTP/PTP/PPS to discipline that counter against an external source of 'real' time, and track the pre