Re: [PATCH v2] gdb: riscv: Add target description

2021-01-06 Thread Alex Bennée
Sylvain Pelissier writes: > Hello, > > I may have made an error by copy pasting the comment into the file. I sent > a new v3 with git send-email. I hope it is fine now. Your v3 doesn't include the review tags you got for v2 which makes it look un-reviewed. See: https://wiki.qemu.org/Contri

Re: [PATCH v2] gdb: riscv: Add target description

2021-01-06 Thread Sylvain Pelissier
Hello, I may have made an error by copy pasting the comment into the file. I sent a new v3 with git send-email. I hope it is fine now. Regards Sylvain On Tue, 5 Jan 2021 at 22:03, Alistair Francis wrote: > On Wed, Dec 30, 2020 at 12:26 AM Sylvain Pelissier > wrote: > > > > Target description

Re: [PATCH v2] gdb: riscv: Add target description

2021-01-05 Thread Alistair Francis
On Wed, Dec 30, 2020 at 12:26 AM Sylvain Pelissier wrote: > > Target description is not currently implemented in RISC-V architecture. Thus > GDB won't set it properly when attached. The patch implements the target > description response. > > Signed-off-by: Sylvain Pelissier Hello, This patch

Re: [PATCH v2] gdb: riscv: Add target description

2021-01-05 Thread Alistair Francis
On Wed, Dec 30, 2020 at 12:26 AM Sylvain Pelissier wrote: > > Target description is not currently implemented in RISC-V architecture. Thus > GDB won't set it properly when attached. The patch implements the target > description response. > > Signed-off-by: Sylvain Pelissier Reviewed-by: Alista

Re: [PATCH v2] gdb: riscv: Add target description

2020-12-30 Thread Bin Meng
On Wed, Dec 30, 2020 at 4:25 PM Sylvain Pelissier wrote: > > Target description is not currently implemented in RISC-V architecture. Thus > GDB won't set it properly when attached. The patch implements the target > description response. > > Signed-off-by: Sylvain Pelissier > --- > target/riscv

[PATCH v2] gdb: riscv: Add target description

2020-12-30 Thread Sylvain Pelissier
Target description is not currently implemented in RISC-V architecture. Thus GDB won't set it properly when attached. The patch implements the target description response. Signed-off-by: Sylvain Pelissier --- target/riscv/cpu.c | 13 + 1 file changed, 13 insertions(+) diff --git a/t