Re: [PATCH v2] file-posix: detect the lock using the real file

2020-12-10 Thread Feng Li
Ok, I see. I will split the detect lock without changing the global variable to a separate function. Don't call the qemu_has_ofd_lock. Thanks. Daniel P. Berrangé 于2020年12月10日周四 下午11:59写道: > > On Wed, Dec 09, 2020 at 12:54:48PM +0800, Li Feng wrote: > > This patch addresses this issue: > > When ac

Re: [PATCH v2] file-posix: detect the lock using the real file

2020-12-10 Thread Daniel P . Berrangé
On Wed, Dec 09, 2020 at 12:54:48PM +0800, Li Feng wrote: > This patch addresses this issue: > When accessing a volume on an NFS filesystem without supporting the file lock, > tools, like qemu-img, will complain "Failed to lock byte 100". > > In the original code, the qemu_has_ofd_lock will test th

[PATCH v2] file-posix: detect the lock using the real file

2020-12-10 Thread Li Feng
This patch addresses this issue: When accessing a volume on an NFS filesystem without supporting the file lock, tools, like qemu-img, will complain "Failed to lock byte 100". In the original code, the qemu_has_ofd_lock will test the lock on the "/dev/null" pseudo-file. Actually, the file.locking i

[PATCH v2] file-posix: detect the lock using the real file

2020-12-08 Thread Li Feng
This patch addresses this issue: When accessing a volume on an NFS filesystem without supporting the file lock, tools, like qemu-img, will complain "Failed to lock byte 100". In the original code, the qemu_has_ofd_lock will test the lock on the "/dev/null" pseudo-file. Actually, the file.locking i