Re: [PATCH v2] docs: Add '-device intel-iommu' entry

2021-07-11 Thread Eric Auger
Hi Peter, On 7/7/21 5:41 PM, Peter Xu wrote: > The parameters of intel-iommu device are non-trivial to understand. Add an > entry for it so that people can reference to it when using. > > There're actually a few more options there, but I hide them explicitly because > they shouldn't be used by n

Re: [PATCH v2] docs: Add '-device intel-iommu' entry

2021-07-09 Thread Michael S. Tsirkin
On Thu, Jul 08, 2021 at 04:28:01PM -0400, Peter Xu wrote: > On Thu, Jul 08, 2021 at 01:17:50AM +0300, Maxim Levitsky wrote: > > As far as I know this looks very good. > > Thanks for doing this! > > > > Reviewed-by: Maxim Levitsky > > Thanks! > > Michael - I just saw a pull req sent, so I wanted

Re: [PATCH v2] docs: Add '-device intel-iommu' entry

2021-07-08 Thread Peter Xu
On Thu, Jul 08, 2021 at 01:17:50AM +0300, Maxim Levitsky wrote: > As far as I know this looks very good. > Thanks for doing this! > > Reviewed-by: Maxim Levitsky Thanks! Michael - I just saw a pull req sent, so I wanted to double check: should this patch go through your tree at last? Thanks,

Re: [PATCH v2] docs: Add '-device intel-iommu' entry

2021-07-07 Thread Maxim Levitsky
On Wed, 2021-07-07 at 11:41 -0400, Peter Xu wrote: > The parameters of intel-iommu device are non-trivial to understand. Add an > entry for it so that people can reference to it when using. > > There're actually a few more options there, but I hide them explicitly because > they shouldn't be used

[PATCH v2] docs: Add '-device intel-iommu' entry

2021-07-07 Thread Peter Xu
The parameters of intel-iommu device are non-trivial to understand. Add an entry for it so that people can reference to it when using. There're actually a few more options there, but I hide them explicitly because they shouldn't be used by normal QEMU users. Cc: Chao Yang Cc: Lei Yang Cc: Jing