Re: [PATCH v2] docs/devel: add some notes on tcg-icount for developers

2020-06-22 Thread Alex Bennée
Alex Bennée writes: > This attempts to bring together my understanding of the requirements > for icount behaviour into one reference document for our developer > notes. It currently make one piece of conjecture which I think is true > that we don't need gen_io_start/end statements for non-MMIO

Re: [PATCH v2] docs/devel: add some notes on tcg-icount for developers

2020-06-20 Thread Richard Henderson
On 6/19/20 10:09 AM, Alex Bennée wrote: > +TCG has long supported a feature known as icount which allows for > +instruction counting during execution. This should be confused with should not be > +cycle accurate emulation - QEMU does not attempt to emulate how long --- for em-dash, iirc, and (te

Re: [PATCH v2] docs/devel: add some notes on tcg-icount for developers

2020-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200619170930.11704-1-alex.ben...@linaro.org/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH v2] docs/devel: add some notes on tcg-icount for developers

2020-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200619170930.11704-1-alex.ben...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v2] docs/devel: add some notes on tcg-icount for developers

2020-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200619170930.11704-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2] docs/devel: add some notes on tcg-icount for developers Type: series Message-id

[PATCH v2] docs/devel: add some notes on tcg-icount for developers

2020-06-19 Thread Alex Bennée
This attempts to bring together my understanding of the requirements for icount behaviour into one reference document for our developer notes. It currently make one piece of conjecture which I think is true that we don't need gen_io_start/end statements for non-MMIO related I/O operations. Signed-