Re: [PATCH v2] cpus: Fix botched configure_icount() error API violation fix

2020-05-21 Thread Paolo Bonzini
On 15/05/20 06:22, Markus Armbruster wrote: > Before recent commit abc9bf69a66, configure_icount() returned early > when option "shift" was absent: succeed when option "align" was also > absent, else fail. > > Since then, it still errors out when only "align" is present, but > continues when both

Re: [PATCH v2] cpus: Fix botched configure_icount() error API violation fix

2020-05-14 Thread Philippe Mathieu-Daudé
On 5/15/20 6:22 AM, Markus Armbruster wrote: Before recent commit abc9bf69a66, configure_icount() returned early when option "shift" was absent: succeed when option "align" was also absent, else fail. Since then, it still errors out when only "align" is present, but continues when both are absen

[PATCH v2] cpus: Fix botched configure_icount() error API violation fix

2020-05-14 Thread Markus Armbruster
Before recent commit abc9bf69a66, configure_icount() returned early when option "shift" was absent: succeed when option "align" was also absent, else fail. Since then, it still errors out when only "align" is present, but continues when both are absent. Crashes when examining the value of "shift"