Re: [PATCH v2] coroutine-ucontext: Save fake stack for pooled coroutine

2024-01-17 Thread Stefan Hajnoczi
On Wed, Jan 17, 2024 at 04:06:02PM +0900, Akihiko Odaki wrote: > Coroutine may be pooled even after COROUTINE_TERMINATE if > CONFIG_COROUTINE_POOL is enabled and fake stack should be saved in > such a case to keep AddressSanitizerUseAfterReturn working. Even worse, > I'm seeing stack corruption wit

Re: [PATCH v2] coroutine-ucontext: Save fake stack for pooled coroutine

2024-01-16 Thread Marc-André Lureau
Hi On Wed, Jan 17, 2024 at 11:26 AM Marc-André Lureau wrote: > > Hi > > On Wed, Jan 17, 2024 at 11:06 AM Akihiko Odaki > wrote: > > > > Coroutine may be pooled even after COROUTINE_TERMINATE if > > CONFIG_COROUTINE_POOL is enabled and fake stack should be saved in > > such a case to keep Addres

Re: [PATCH v2] coroutine-ucontext: Save fake stack for pooled coroutine

2024-01-16 Thread Marc-André Lureau
Hi On Wed, Jan 17, 2024 at 11:06 AM Akihiko Odaki wrote: > > Coroutine may be pooled even after COROUTINE_TERMINATE if > CONFIG_COROUTINE_POOL is enabled and fake stack should be saved in > such a case to keep AddressSanitizerUseAfterReturn working. Even worse, > I'm seeing stack corruption witho

[PATCH v2] coroutine-ucontext: Save fake stack for pooled coroutine

2024-01-16 Thread Akihiko Odaki
Coroutine may be pooled even after COROUTINE_TERMINATE if CONFIG_COROUTINE_POOL is enabled and fake stack should be saved in such a case to keep AddressSanitizerUseAfterReturn working. Even worse, I'm seeing stack corruption without fake stack being saved. Signed-off-by: Akihiko Odaki --- Changes