Re: [PATCH v2] char-socket: initialize reconnect timer only when the timer doesn't start

2020-04-28 Thread Feng Li
Apply the above patch, then `make check-unit` or `tests/test-char -p /char/socket/client/reconnect-error/unix` Marc-André Lureau 于2020年4月28日周二 下午7:06写道: > > Hi > > On Tue, Apr 28, 2020 at 10:59 AM Li Feng wrote: > > > > Sorry for sending the weird same mail out. > > Ignore the second one. > > >

Re: [PATCH v2] char-socket: initialize reconnect timer only when the timer doesn't start

2020-04-28 Thread Marc-André Lureau
Hi On Tue, Apr 28, 2020 at 10:59 AM Li Feng wrote: > > Sorry for sending the weird same mail out. > Ignore the second one. > > Hi Lureau, > > I found another issue when running my new test: tests/test-char -p > /char/socket/client/reconnect-error/unix > The backtrace like this: > #0 0x7

[PATCH v2] char-socket: initialize reconnect timer only when the timer doesn't start

2020-04-28 Thread Li Feng
When the disconnect event is triggered in the connecting stage, the tcp_chr_disconnect_locked may be called twice. The first call: #0 qemu_chr_socket_restart_timer (chr=0x5582ee90) at chardev/char-socket.c:120 #1 0x5558e38c in tcp_chr_disconnect_locked (chr=) at chardev/cha

[PATCH v2] char-socket: initialize reconnect timer only when the timer doesn't start

2020-04-28 Thread Li Feng
When the disconnect event is triggered in the connecting stage, the tcp_chr_disconnect_locked may be called twice. The first call: #0 qemu_chr_socket_restart_timer (chr=0x5582ee90) at chardev/char-socket.c:120 #1 0x5558e38c in tcp_chr_disconnect_locked (chr=) at chardev/cha

Re: [PATCH v2] char-socket: initialize reconnect timer only when the timer doesn't start

2020-04-28 Thread Li Feng
Sorry for sending the weird same mail out. Ignore the second one. Hi Lureau, I found another issue when running my new test: tests/test-char -p /char/socket/client/reconnect-error/unix The backtrace like this: #0 0x75ac3277 in raise () from /lib64/libc.so.6 #1 0x75ac4968 in abo