Re: [PATCH v2] capstone: use instead of

2022-11-17 Thread Paolo Bonzini
On 11/15/22 09:11, Daniel P. Berrangé wrote: On Mon, Nov 14, 2022 at 02:49:39PM +0100, Paolo Bonzini wrote: Queued, thanks. I presume you have unqueued this patch again after the discussion yesterday ? Yes, of course. Paolo

Re: [PATCH v2] capstone: use instead of

2022-11-15 Thread Michael Tokarev
15.11.2022 14:00, Peter Maydell wrote: .. https://mesonbuild.com/Reference-manual_returned_compiler.html#compilerhas_header "dependencies dep | list[dep] Additionally dependencies required for compiling and / or linking." Oh sh**t.. I mistypoed it initially :) It looks like I "un-learned" t

Re: [PATCH v2] capstone: use instead of

2022-11-15 Thread Peter Maydell
On Tue, 15 Nov 2022 at 11:00, Peter Maydell wrote: > > On Tue, 15 Nov 2022 at 09:25, Michael Tokarev wrote: > > > > 14.11.2022 14:59, Peter Maydell wrote: > > .. > > > We can do something like > > > > > > config_host_data.set('HAVE_CAPSTONE_CAPSTONE_H', > > > cc.has_header('capstone/capstone.h',

Re: [PATCH v2] capstone: use instead of

2022-11-15 Thread Peter Maydell
On Tue, 15 Nov 2022 at 09:25, Michael Tokarev wrote: > > 14.11.2022 14:59, Peter Maydell wrote: > .. > > We can do something like > > > > config_host_data.set('HAVE_CAPSTONE_CAPSTONE_H', > > cc.has_header('capstone/capstone.h', depedencies: [capstone]) > > This doesn't work, because has_header doe

Re: [PATCH v2] capstone: use instead of

2022-11-15 Thread Michael Tokarev
14.11.2022 14:59, Peter Maydell wrote: .. We can do something like config_host_data.set('HAVE_CAPSTONE_CAPSTONE_H', cc.has_header('capstone/capstone.h', depedencies: [capstone]) This doesn't work, because has_header does not have "dependencies" argument. And without that, it doesn't take pkgc

Re: [PATCH v2] capstone: use instead of

2022-11-15 Thread Daniel P . Berrangé
On Mon, Nov 14, 2022 at 02:49:39PM +0100, Paolo Bonzini wrote: > Queued, thanks. I presume you have unqueued this patch again after the discussion yesterday ? With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [PATCH v2] capstone: use instead of

2022-11-14 Thread Daniel P . Berrangé
On Mon, Nov 14, 2022 at 12:13:48PM +0300, Michael Tokarev wrote: > 14.11.2022 11:58, Daniel P. Berrangé wrote: > .. > > > On current systems, using works > > > now (despite the pkg-config-supplied -I/usr/include/capstone) - > > > since on all systems capstone headers are put into capstone/ > > > s

Re: [PATCH v2] capstone: use instead of

2022-11-14 Thread Daniel P . Berrangé
On Sun, Nov 13, 2022 at 11:09:42PM +0300, Michael Tokarev wrote: > The upcoming capstone 5.0 drops support for the old way > of including its header, due to this change: > https://github.com/capstone-engine/capstone/commit/6656bcb63ab4e87dc6079bd6b6b12cc8dd9b2ad8 > The official way is to use > >

Re: [PATCH v2] capstone: use instead of

2022-11-14 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH v2] capstone: use instead of

2022-11-14 Thread Peter Maydell
On Sun, 13 Nov 2022 at 20:10, Michael Tokarev wrote: > > The upcoming capstone 5.0 drops support for the old way > of including its header, due to this change: > https://github.com/capstone-engine/capstone/commit/6656bcb63ab4e87dc6079bd6b6b12cc8dd9b2ad8 > The official way is to use > > This chang

Re: [PATCH v2] capstone: use instead of

2022-11-14 Thread Daniel P . Berrangé
On Mon, Nov 14, 2022 at 11:59:31AM +, Peter Maydell wrote: > On Sun, 13 Nov 2022 at 20:10, Michael Tokarev wrote: > > > > The upcoming capstone 5.0 drops support for the old way > > of including its header, due to this change: > > https://github.com/capstone-engine/capstone/commit/6656bcb63ab4

Re: [PATCH v2] capstone: use instead of

2022-11-14 Thread Michael Tokarev
14.11.2022 11:58, Daniel P. Berrangé wrote: .. On current systems, using works now (despite the pkg-config-supplied -I/usr/include/capstone) - since on all systems capstone headers are put into capstone/ subdirectory of a system include dir. So this change is compatible with both the obsolete wa

[PATCH v2] capstone: use instead of

2022-11-13 Thread Michael Tokarev
The upcoming capstone 5.0 drops support for the old way of including its header, due to this change: https://github.com/capstone-engine/capstone/commit/6656bcb63ab4e87dc6079bd6b6b12cc8dd9b2ad8 The official way is to use This change has already been proposed before, see https://patchwork.kernel.or