Re: [PATCH v2] blockdev-backup: Add error handling option for copy-before-write jobs

2025-04-14 Thread Vladimir Sementsov-Ogievskiy
On 14.04.25 04:30, Raman Dzehtsiar wrote: Hi Vladimir, Thank you for your review. The patch looks good to me. Still, could you also provide a test for a new option? Probably the simplest would be add a test-case to `tests/qemu-iotests/tests/copy-before-write`, where existing on-cbw-error opt

Re: [PATCH v2] blockdev-backup: Add error handling option for copy-before-write jobs

2025-04-13 Thread Raman Dzehtsiar
Hi Vladimir, Thank you for your review. > The patch looks good to me. Still, could you also provide a test for a new > option? > Probably the simplest would be add a test-case to > `tests/qemu-iotests/tests/copy-before-write`, where existing on-cbw-error > option is tested. Or you can make a se

Re: [PATCH v2] blockdev-backup: Add error handling option for copy-before-write jobs

2025-03-14 Thread Vladimir Sementsov-Ogievskiy
On 04.03.25 12:17, Raman Dzehtsiar wrote: This patch extends the blockdev-backup QMP command to allow users to specify how to behave when IO errors occur during copy-before-write operations. Previously, the behavior was fixed and could not be controlled by the user. The new 'on-cbw-error' option

Re: [PATCH v2] blockdev-backup: Add error handling option for copy-before-write jobs

2025-03-11 Thread Raman Dzehtsiar
On Tue, Mar 4, 2025 at 10:17 AM Raman Dzehtsiar wrote: > > This patch extends the blockdev-backup QMP command to allow users to specify > how to behave when IO errors occur during copy-before-write operations. > Previously, the behavior was fixed and could not be controlled by the user. > > The ne

[PATCH v2] blockdev-backup: Add error handling option for copy-before-write jobs

2025-03-04 Thread Raman Dzehtsiar
This patch extends the blockdev-backup QMP command to allow users to specify how to behave when IO errors occur during copy-before-write operations. Previously, the behavior was fixed and could not be controlled by the user. The new 'on-cbw-error' option can be set to one of two values: - 'break-g