Re: [PATCH v2] block/gluster: correctly set max_pdiscard

2022-05-13 Thread Fabian Ebner
Am 12.05.22 um 18:05 schrieb Stefano Garzarella: > On Thu, May 12, 2022 at 05:44:13PM +0200, Stefano Garzarella wrote: >> On Thu, May 12, 2022 at 12:30:48PM +0200, Fabian Ebner wrote: >>> On 64-bit platforms, SIZE_MAX is too large for max_pdiscard, which is >> >> The main problem is that SIZE_MAX f

Re: [PATCH v2] block/gluster: correctly set max_pdiscard

2022-05-12 Thread Stefano Garzarella
On Thu, May 12, 2022 at 05:44:13PM +0200, Stefano Garzarella wrote: On Thu, May 12, 2022 at 12:30:48PM +0200, Fabian Ebner wrote: On 64-bit platforms, SIZE_MAX is too large for max_pdiscard, which is The main problem is that SIZE_MAX for an int64_t is a negative value. int64_t, and the follo

Re: [PATCH v2] block/gluster: correctly set max_pdiscard

2022-05-12 Thread Stefano Garzarella
On Thu, May 12, 2022 at 12:30:48PM +0200, Fabian Ebner wrote: On 64-bit platforms, SIZE_MAX is too large for max_pdiscard, which is The main problem is that SIZE_MAX for an int64_t is a negative value. int64_t, and the following assertion would be triggered: qemu-system-x86_64: ../block/io.c:

[PATCH v2] block/gluster: correctly set max_pdiscard

2022-05-12 Thread Fabian Ebner
On 64-bit platforms, SIZE_MAX is too large for max_pdiscard, which is int64_t, and the following assertion would be triggered: qemu-system-x86_64: ../block/io.c:3166: bdrv_co_pdiscard: Assertion `max_pdiscard >= bs->bl.request_alignment' failed. Fixes: 0c8022876f ("block: use int64_t instead of in