Re: [PATCH v2] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-16 Thread Dorinda Bassey
> > BUFFER_SAMPLES is not used anywhere, and in code you are using 512 as > literals > instead. That was an oversight indeed, It's intended use was removed. s/buffer/ringbuffer/ maybe? > I think the naming convention 'buffer' is good. I would not use literals for period size and number of period

Re: [PATCH v2] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-16 Thread Christian Schoenebeck
On Thursday, February 16, 2023 9:25:44 AM CET Dorinda Bassey wrote: > This commit adds a new audiodev backend to allow QEMU to use Pipewire as both > an audio sink and source. > Please wrap commit log. > Signed-off-by: Dorinda Bassey > --- > v2: > * Shorten commit message > * fix copyright own

[PATCH v2] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-16 Thread Dorinda Bassey
This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. Signed-off-by: Dorinda Bassey --- v2: * Shorten commit message * fix copyright ownership and authour * use QEMU standard of 4 space indentation * verbose use of pipewire instead pf pw audio/