Re: [PATCH v2] Only advertise aio=io_uring if support is actually available

2022-04-25 Thread Eric Blake
On Mon, Apr 25, 2022 at 12:19:08PM +0100, Daniel P. Berrangé wrote: > On Fri, Apr 22, 2022 at 03:30:46PM -0500, Eric Blake wrote: > > On Thu, Apr 21, 2022 at 02:27:55PM -0500, Eric Blake wrote: > > > On Thu, Apr 21, 2022 at 06:50:48PM +0200, Dirk Müller wrote: > > > > Change --help output for aio o

Re: [PATCH v2] Only advertise aio=io_uring if support is actually available

2022-04-25 Thread Daniel P . Berrangé
On Fri, Apr 22, 2022 at 03:30:46PM -0500, Eric Blake wrote: > On Thu, Apr 21, 2022 at 02:27:55PM -0500, Eric Blake wrote: > > On Thu, Apr 21, 2022 at 06:50:48PM +0200, Dirk Müller wrote: > > > Change --help output for aio option to only list the aio backend options > > > that > > > are actually av

Re: [PATCH v2] Only advertise aio=io_uring if support is actually available

2022-04-22 Thread Eric Blake
On Thu, Apr 21, 2022 at 02:27:55PM -0500, Eric Blake wrote: > On Thu, Apr 21, 2022 at 06:50:48PM +0200, Dirk Müller wrote: > > Change --help output for aio option to only list the aio backend options > > that > > are actually available. io_uring is an optional, linux only backend > > option so hid

Re: [PATCH v2] Only advertise aio=io_uring if support is actually available

2022-04-21 Thread Eric Blake
On Thu, Apr 21, 2022 at 06:50:48PM +0200, Dirk Müller wrote: > Change --help output for aio option to only list the aio backend options that > are actually available. io_uring is an optional, linux only backend > option so hide it for cases where it isn't there. As pointed out by Dan, this commit

[PATCH v2] Only advertise aio=io_uring if support is actually available

2022-04-21 Thread Dirk Müller
Change --help output for aio option to only list the aio backend options that are actually available. io_uring is an optional, linux only backend option so hide it for cases where it isn't there. Reviewed-by: Eric Blake Signed-off-by: Dirk Müller --- block/file-posix.c | 4 qemu-nbd.c