Re: [PATCH v16 78/99] target/arm: cpu-exceptions, cpu-exceptions-aa64: new modules

2021-06-10 Thread Claudio Fontana
On 6/10/21 11:01 AM, Peter Maydell wrote: > On Thu, 10 Jun 2021 at 09:45, Claudio Fontana wrote: >> >> On 6/5/21 10:50 PM, Richard Henderson wrote: >>> I don't see the point in the excessive replication of header files, for >>> exactly >>> one declaration. This is not the first example. >>> >>>

Re: [PATCH v16 78/99] target/arm: cpu-exceptions, cpu-exceptions-aa64: new modules

2021-06-10 Thread Peter Maydell
On Thu, 10 Jun 2021 at 09:45, Claudio Fontana wrote: > > On 6/5/21 10:50 PM, Richard Henderson wrote: > > I don't see the point in the excessive replication of header files, for > > exactly > > one declaration. This is not the first example. > > > > What's wrong with internal.h? > > Doesn't mean

Re: [PATCH v16 78/99] target/arm: cpu-exceptions, cpu-exceptions-aa64: new modules

2021-06-10 Thread Claudio Fontana
On 6/5/21 10:50 PM, Richard Henderson wrote: > On 6/4/21 8:52 AM, Alex Bennée wrote: >> diff --git a/target/arm/cpu-exceptions-aa64.h >> b/target/arm/cpu-exceptions-aa64.h >> new file mode 100644 >> index 00..64f800a15d >> --- /dev/null >> +++ b/target/arm/cpu-exceptions-aa64.h >> @@ -0,0

Re: [PATCH v16 78/99] target/arm: cpu-exceptions, cpu-exceptions-aa64: new modules

2021-06-05 Thread Richard Henderson
On 6/4/21 8:52 AM, Alex Bennée wrote: From: Claudio Fontana after restricting AArch64-specific code to TARGET_AARCH64 builds, we can now extract the exception handling code from cpu-sysemu, and split its AArch64-specific part into its own module. Signed-off-by: Claudio Fontana Signed-off-by:

Re: [PATCH v16 78/99] target/arm: cpu-exceptions, cpu-exceptions-aa64: new modules

2021-06-05 Thread Richard Henderson
On 6/4/21 8:52 AM, Alex Bennée wrote: diff --git a/target/arm/cpu-exceptions-aa64.h b/target/arm/cpu-exceptions-aa64.h new file mode 100644 index 00..64f800a15d --- /dev/null +++ b/target/arm/cpu-exceptions-aa64.h @@ -0,0 +1,28 @@ +/* + * QEMU AArch64 CPU Exceptions Sysemu code + * + * Co

[PATCH v16 78/99] target/arm: cpu-exceptions, cpu-exceptions-aa64: new modules

2021-06-04 Thread Alex Bennée
From: Claudio Fontana after restricting AArch64-specific code to TARGET_AARCH64 builds, we can now extract the exception handling code from cpu-sysemu, and split its AArch64-specific part into its own module. Signed-off-by: Claudio Fontana Signed-off-by: Alex Bennée --- target/arm/cpu-excepti