Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-04-28 Thread Nagy Vani

Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-03-02 Thread Pierre Morel
On 2/24/23 18:15, Nina Schoetterl-Glausch wrote: On Wed, 2023-02-22 at 15:21 +0100, Pierre Morel wrote: [...] diff --git a/hmp-commands.hx b/hmp-commands.hx index fbb5daf09b..d8c37808c7 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1815,3 +1815,20 @@ SRST Dump the FDT in dtb form

Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-02-27 Thread Markus Armbruster
Nina Schoetterl-Glausch writes: > CpuS390Entitlement would be useful in both machine.json and > machine-target.json > because query-cpu-fast is defined in machine.json and set-cpu-topology is > defined > in machine-target.json. > So then the question is where best to define CpuS390Entitlement.

Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-02-27 Thread Pierre Morel
On 2/27/23 13:15, Nina Schoetterl-Glausch wrote: On Mon, 2023-02-27 at 11:57 +0100, Pierre Morel wrote: On 2/24/23 18:15, Nina Schoetterl-Glausch wrote: On Wed, 2023-02-22 at 15:21 +0100, Pierre Morel wrote: The modification of the CPU attributes are done through a monitor command. It allow

Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-02-27 Thread Nina Schoetterl-Glausch
On Mon, 2023-02-27 at 13:25 +0100, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > On Mon, 2023-02-27 at 08:59 +0100, Thomas Huth wrote: > > [...] > > > > I'm not sure whether double inclusion works with the QAPI parser (since > > > this > > > might code to be generated twice

Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-02-27 Thread Markus Armbruster
Nina Schoetterl-Glausch writes: > On Mon, 2023-02-27 at 08:59 +0100, Thomas Huth wrote: [...] >> I'm not sure whether double inclusion works with the QAPI parser (since this >> might code to be generated twice) ... have you tried? > > I haven't, the documentation says: > >> Include directives

Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-02-27 Thread Nina Schoetterl-Glausch
On Mon, 2023-02-27 at 11:57 +0100, Pierre Morel wrote: > On 2/24/23 18:15, Nina Schoetterl-Glausch wrote: > > On Wed, 2023-02-22 at 15:21 +0100, Pierre Morel wrote: > > > The modification of the CPU attributes are done through a monitor > > > command. > > > > > > It allows to move the core inside

Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-02-27 Thread Thomas Huth
On 27/02/2023 11.57, Pierre Morel wrote: On 2/24/23 18:15, Nina Schoetterl-Glausch wrote: On Wed, 2023-02-22 at 15:21 +0100, Pierre Morel wrote: The modification of the CPU attributes are done through a monitor command. It allows to move the core inside the topology tree to optimize the cache

Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-02-27 Thread Pierre Morel
On 2/24/23 18:15, Nina Schoetterl-Glausch wrote: On Wed, 2023-02-22 at 15:21 +0100, Pierre Morel wrote: The modification of the CPU attributes are done through a monitor command. It allows to move the core inside the topology tree to optimize the cache usage in the case the host's hypervisor

Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-02-27 Thread Nina Schoetterl-Glausch
On Mon, 2023-02-27 at 08:59 +0100, Thomas Huth wrote: > On 24/02/2023 18.15, Nina Schoetterl-Glausch wrote: > > On Wed, 2023-02-22 at 15:21 +0100, Pierre Morel wrote: > > > The modification of the CPU attributes are done through a monitor > > > command. > > > > > > It allows to move the core insid

Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-02-27 Thread Pierre Morel
/o\ Sorry, I changed the HMP arguments in the C code from core.. to core-id.. and forgot to change them inside the hmp-command.hx file. Also I need to extend the info hotpluggable-cpus. I will provide alternate patches with these two corrections. Regards, Pierre On Wed, 2023-02-22 at 15:21

Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-02-27 Thread Thomas Huth
On 24/02/2023 18.15, Nina Schoetterl-Glausch wrote: On Wed, 2023-02-22 at 15:21 +0100, Pierre Morel wrote: The modification of the CPU attributes are done through a monitor command. It allows to move the core inside the topology tree to optimize the cache usage in the case the host's hypervisor

Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-02-24 Thread Nina Schoetterl-Glausch
On Wed, 2023-02-22 at 15:21 +0100, Pierre Morel wrote: > The modification of the CPU attributes are done through a monitor > command. > > It allows to move the core inside the topology tree to optimize > the cache usage in the case the host's hypervisor previously > moved the CPU. > > The same co

[PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

2023-02-22 Thread Pierre Morel
The modification of the CPU attributes are done through a monitor command. It allows to move the core inside the topology tree to optimize the cache usage in the case the host's hypervisor previously moved the CPU. The same command allows to modify the CPU attributes modifiers like polarization e