Re: [PATCH v14 15/22] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass

2021-02-02 Thread Claudio Fontana
On 2/2/21 11:01 AM, Claudio Fontana wrote: > On 1/29/21 1:31 AM, Richard Henderson wrote: >> On 1/27/21 11:28 PM, Claudio Fontana wrote: >>> +/* >>> + * NB: this should be covered by CONFIG_TCG, but it is unsafe to do it >>> here, >>> + * as this header is included by both ss_specific

Re: [PATCH v14 15/22] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass

2021-02-02 Thread Claudio Fontana
On 1/29/21 1:31 AM, Richard Henderson wrote: > On 1/27/21 11:28 PM, Claudio Fontana wrote: >> +/* >> + * NB: this should be covered by CONFIG_TCG, but it is unsafe to do it >> here, >> + * as this header is included by both ss_specific and ss_common code, >> + * leading to potentia

Re: [PATCH v14 15/22] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass

2021-01-30 Thread Claudio Fontana
On 1/29/21 8:36 PM, Eduardo Habkost wrote: > On Fri, Jan 29, 2021 at 09:19:00AM -1000, Richard Henderson wrote: >> On 1/28/21 11:00 PM, Claudio Fontana wrote: >>> Do you think I should redo the series anyway? I would have started this way >>> in the first place, but I tried not to redo Eduardo's wo

Re: [PATCH v14 15/22] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass

2021-01-29 Thread Eduardo Habkost
On Fri, Jan 29, 2021 at 09:19:00AM -1000, Richard Henderson wrote: > On 1/28/21 11:00 PM, Claudio Fontana wrote: > > Do you think I should redo the series anyway? I would have started this way > > in the first place, but I tried not to redo Eduardo's work. > I think that would be a good idea, yes.

Re: [PATCH v14 15/22] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass

2021-01-29 Thread Richard Henderson
On 1/28/21 11:00 PM, Claudio Fontana wrote: > Do you think I should redo the series anyway? I would have started this way > in the first place, but I tried not to redo Eduardo's work. I think that would be a good idea, yes. r~

Re: [PATCH v14 15/22] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass

2021-01-29 Thread Claudio Fontana
On 1/29/21 1:31 AM, Richard Henderson wrote: > On 1/27/21 11:28 PM, Claudio Fontana wrote: >> +/* >> + * NB: this should be covered by CONFIG_TCG, but it is unsafe to do it >> here, >> + * as this header is included by both ss_specific and ss_common code, >> + * leading to potentia

Re: [PATCH v14 15/22] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass

2021-01-28 Thread Richard Henderson
On 1/27/21 11:28 PM, Claudio Fontana wrote: > +/* > + * NB: this should be covered by CONFIG_TCG, but it is unsafe to do it > here, > + * as this header is included by both ss_specific and ss_common code, > + * leading to potential differences in the data structure between > modul

[PATCH v14 15/22] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass

2021-01-28 Thread Claudio Fontana
this improves over the workaround in commit ("cpu: move cc->transaction_failed to tcg_ops") by moving the tcg cpu operations into a separate file, which is only included by target-specific code. The context is that code in ss_common and ss_specific modules might see different data structure layou