Re: [PATCH v13 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-21 Thread Laurent Vivier
On 10/21/22 08:50, Jason Wang wrote: On Fri, Oct 21, 2022 at 2:46 PM Markus Armbruster wrote: Jason Wang writes: I've queued this version and will send pull requests shortly. Any future comment we can do patches on top. Please give Laurent and me a few hours to try to improve PATCH 17's

Re: [PATCH v13 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-20 Thread Jason Wang
On Fri, Oct 21, 2022 at 2:46 PM Markus Armbruster wrote: > > Jason Wang writes: > > > I've queued this version and will send pull requests shortly. > > > > Any future comment we can do patches on top. > > Please give Laurent and me a few hours to try to improve PATCH 17's > commit message. Which

Re: [PATCH v13 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-20 Thread Markus Armbruster
Jason Wang writes: > I've queued this version and will send pull requests shortly. > > Any future comment we can do patches on top. Please give Laurent and me a few hours to try to improve PATCH 17's commit message. Which you could then integrate without a respin.

Re: [PATCH v13 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-20 Thread Jason Wang
On Fri, Oct 21, 2022 at 12:26 AM Laurent Vivier wrote: > > "-netdev socket" only supports inet sockets. > > It's not a complex task to add support for unix sockets, but > the socket netdev parameters are not defined to manage well unix > socket parameters. > > As discussed in: > > "socket.c adde

[PATCH v13 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-20 Thread Laurent Vivier
"-netdev socket" only supports inet sockets. It's not a complex task to add support for unix sockets, but the socket netdev parameters are not defined to manage well unix socket parameters. As discussed in: "socket.c added support for unix domain socket datagram transport" https://lore.kern