Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-25 Thread Richard Henderson
On 11/25/21 4:03 AM, gaosong wrote: I also see that TARGET_SIGSTKSZ is not used.  I think  we should delete it. Agreed. This constant will have been baked into the guest executable. r~

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-24 Thread gaosong
Hi  Richard, On 2021/11/20 下午6:33, Richard Henderson wrote: +/* this struct defines a stack used during syscall handling */ +typedef struct target_sigaltstack { +    abi_long ss_sp; +    abi_int ss_flags; +    abi_ulong ss_size; +} target_stack_t; + +/* + * sigaltstack controls + */ +

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-24 Thread Richard Henderson
On 11/24/21 11:22 AM, gaosong wrote: I see that  kernel  define  the fcc used type uint64_t,   and  used movgr2cf/movcf2gr save and restore the fcc0-fcc7. but  qemu define  fcc0-fcc7 as  bool cf[8] at target/loongarch/cpu.h,   how qemu can save/restore fcc,  Do you have any idea? Does we can

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-24 Thread gaosong
Hi Richard, On 2021/11/20 下午6:33, Richard Henderson wrote: +{ +    int i; + +    __put_user(env->pc, &sc->sc_pc); + +    __put_user(0, &sc->sc_gpr[0]); +    for (i = 1; i < 32; ++i) { +    __put_user(env->gpr[i], &sc->sc_gpr[i]); +    } + +    for (i = 0; i < 32; ++i) { +    __put_user(en

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-24 Thread Richard Henderson
On 11/24/21 8:50 AM, gaosong wrote: No, sc_reserved does not match. uint8   sc_reserved[4096] __attribute__((aligned(16))); Yes. BTW, should we set scr[0-3] as 0 ? I think so. The LoongArch Reference Manual, Volume 3: Virtualization and Binary Translation Extensions, v1.00, is empty.

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-23 Thread gaosong
Hi Richard, On 2021/11/24 下午3:27, Richard Henderson wrote: On 11/24/21 3:46 AM, gaosong wrote: Hi Richard, On 2021/11/20 下午6:33, Richard Henderson wrote: On 11/19/21 7:13 AM, Song Gao wrote: + +struct target_sigcontext { +    uint64_t   sc_pc; +    uint64_t   sc_gpr[32]; +    uint64_t   sc_

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-23 Thread Richard Henderson
On 11/24/21 3:46 AM, gaosong wrote: Hi Richard, On 2021/11/20 下午6:33, Richard Henderson wrote: On 11/19/21 7:13 AM, Song Gao wrote: + +struct target_sigcontext { +    uint64_t   sc_pc; +    uint64_t   sc_gpr[32]; +    uint64_t   sc_fpr[32]; +    uint64_t   sc_fcc; +    uint32_t   sc_fcsr; +  

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-23 Thread gaosong
Hi Richard, On 2021/11/20 下午6:33, Richard Henderson wrote: On 11/19/21 7:13 AM, Song Gao wrote: + +struct target_sigcontext { +    uint64_t   sc_pc; +    uint64_t   sc_gpr[32]; +    uint64_t   sc_fpr[32]; +    uint64_t   sc_fcc; +    uint32_t   sc_fcsr; +    uint32_t   sc_flags; +}; Does not

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-22 Thread Richard Henderson
On 11/22/21 12:41 PM, gaosong wrote: Hi Richard, On 2021/11/20 下午6:33, Richard Henderson wrote: Drop all of the the inline markers. +{ +    int i; + +    __put_user(env->pc, &sc->sc_pc); + +    __put_user(0, &sc->sc_gpr[0]); +    for (i = 1; i < 32; ++i) { +    __put_user(env->gpr[i], &s

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-22 Thread chen huacai
Hi, all, On Mon, Nov 22, 2021 at 7:41 PM gaosong wrote: > > Hi Richard, > > On 2021/11/20 下午6:33, Richard Henderson wrote: > > > Drop all of the the inline markers. > > +{ > +int i; > + > +__put_user(env->pc, &sc->sc_pc); > + > +__put_user(0, &sc->sc_gpr[0]); > +for (i = 1; i < 32

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-22 Thread gaosong
Hi Richard, On 2021/11/20 下午6:33, Richard Henderson wrote: Drop all of the the inline markers. +{ +    int i; + +    __put_user(env->pc, &sc->sc_pc); + +    __put_user(0, &sc->sc_gpr[0]); +    for (i = 1; i < 32; ++i) { +    __put_user(env->gpr[i], &sc->sc_gpr[i]); +    } + +    for (i =

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-20 Thread Richard Henderson
On 11/19/21 7:13 AM, Song Gao wrote: Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- linux-user/loongarch64/signal.c| 162 + linux-user/loongarch64/target_signal.h | 29 ++ 2 files changed, 191 insertions(+) create mode 100644 linux-us

[PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-18 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- linux-user/loongarch64/signal.c| 162 + linux-user/loongarch64/target_signal.h | 29 ++ 2 files changed, 191 insertions(+) create mode 100644 linux-user/loongarch64/signal.c create mode 100644