Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

2021-12-26 Thread Hyman
在 2021/12/24 13:14, Peter Xu 写道: On Tue, Dec 14, 2021 at 07:07:34PM +0800, huang...@chinatelecom.cn wrote: +void qmp_vcpu_dirty_limit(bool enable, + bool has_cpu_index, + uint64_t cpu_index, + bool has_dirty_rate, +

Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

2021-12-23 Thread Peter Xu
On Thu, Dec 16, 2021 at 11:23:37AM +0100, Markus Armbruster wrote: > Hyman Huang writes: > > [...] > > > So the final format of qmp we conclude are: > > > > case 1: setup vcpu 0 dirty page limit 100MB/s > > set-vcpu-dirty-limit cpu-index=0 dirty-rate=100 > > > > case 2: setup all vcpu dirty page

Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

2021-12-23 Thread Peter Xu
On Tue, Dec 14, 2021 at 07:07:34PM +0800, huang...@chinatelecom.cn wrote: > +void qmp_vcpu_dirty_limit(bool enable, > + bool has_cpu_index, > + uint64_t cpu_index, > + bool has_dirty_rate, > + uint64

Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

2021-12-16 Thread Markus Armbruster
Hyman Huang writes: [...] > So the final format of qmp we conclude are: > > case 1: setup vcpu 0 dirty page limit 100MB/s > set-vcpu-dirty-limit cpu-index=0 dirty-rate=100 > > case 2: setup all vcpu dirty page limit 100MB/s > set-vcpu-dirty-limit dirty-rate=100 > > case 3: cancel vcpu 0 dirty pa

Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

2021-12-16 Thread Hyman Huang
在 2021/12/16 14:22, Peter Xu 写道: On Wed, Dec 15, 2021 at 02:41:32PM +0100, Markus Armbruster wrote: Peter Xu writes: On Wed, Dec 15, 2021 at 03:56:55PM +0800, Hyman Huang wrote: +{ 'command': 'vcpu-dirty-limit', + 'data': { 'enable': 'bool', +'*cpu-index': 'uint64', +

Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

2021-12-15 Thread Peter Xu
On Wed, Dec 15, 2021 at 02:41:32PM +0100, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, Dec 15, 2021 at 03:56:55PM +0800, Hyman Huang wrote: > >> > > +{ 'command': 'vcpu-dirty-limit', > >> > > + 'data': { 'enable': 'bool', > >> > > +'*cpu-index': 'uint64', > >> > > +

Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

2021-12-15 Thread Markus Armbruster
Peter Xu writes: > On Wed, Dec 15, 2021 at 03:56:55PM +0800, Hyman Huang wrote: >> > > +{ 'command': 'vcpu-dirty-limit', >> > > + 'data': { 'enable': 'bool', >> > > +'*cpu-index': 'uint64', >> > > +'*dirty-rate': 'uint64'} } >> > >> > Drop @enable, please. >> > >> > If

Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

2021-12-15 Thread Hyman Huang
在 2021/12/15 16:29, Hyman Huang 写道: 在 2021/12/15 16:09, Peter Xu 写道: On Wed, Dec 15, 2021 at 03:56:55PM +0800, Hyman Huang wrote: +{ 'command': 'vcpu-dirty-limit', +  'data': { 'enable': 'bool', +    '*cpu-index': 'uint64', +    '*dirty-rate': 'uint64'} } Drop @enable, pl

Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

2021-12-15 Thread Hyman Huang
在 2021/12/15 16:09, Peter Xu 写道: On Wed, Dec 15, 2021 at 03:56:55PM +0800, Hyman Huang wrote: +{ 'command': 'vcpu-dirty-limit', + 'data': { 'enable': 'bool', +'*cpu-index': 'uint64', +'*dirty-rate': 'uint64'} } Drop @enable, please. If @dirty-rate is present, set t

Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

2021-12-15 Thread Peter Xu
On Wed, Dec 15, 2021 at 03:56:55PM +0800, Hyman Huang wrote: > > > +{ 'command': 'vcpu-dirty-limit', > > > + 'data': { 'enable': 'bool', > > > +'*cpu-index': 'uint64', > > > +'*dirty-rate': 'uint64'} } > > > > Drop @enable, please. > > > > If @dirty-rate is present, set t

Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

2021-12-15 Thread Hyman Huang
在 2021/12/15 15:37, Markus Armbruster 写道: huang...@chinatelecom.cn writes: From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle virtual CPU until it reachs the quota dirty page rate given by user. Introduce qmp commands "vcpu-dirty-limit", "

Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

2021-12-15 Thread Markus Armbruster
huang...@chinatelecom.cn writes: > From: Hyman Huang(黄勇) > > Implement dirtyrate calculation periodically basing on > dirty-ring and throttle virtual CPU until it reachs the quota > dirty page rate given by user. > > Introduce qmp commands "vcpu-dirty-limit", "query-vcpu-dirty-limit" > to enable,

[PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

2021-12-14 Thread huangy81
From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle virtual CPU until it reachs the quota dirty page rate given by user. Introduce qmp commands "vcpu-dirty-limit", "query-vcpu-dirty-limit" to enable, disable, query dirty page limit for virtual CPU