Re: [PATCH v10 02/16] target/riscv: fix clzw implementation to operate on arg1

2021-09-07 Thread Bin Meng
On Sun, Sep 5, 2021 at 4:35 AM Philipp Tomsich wrote: > > The refactored gen_clzw() uses ret as its argument, instead of arg1. > Fix it. > > Signed-off-by: Philipp Tomsich > --- > > Changes in v10: > - New patch, fixing regressions discovered with x264_r. > > target/riscv/insn_trans/trans_rvb.c.

Re: [PATCH v10 02/16] target/riscv: fix clzw implementation to operate on arg1

2021-09-05 Thread Alistair Francis
On Sun, Sep 5, 2021 at 6:36 AM Philipp Tomsich wrote: > > The refactored gen_clzw() uses ret as its argument, instead of arg1. > Fix it. > > Signed-off-by: Philipp Tomsich Reviewed-by: Alistair Francis Alistair > --- > > Changes in v10: > - New patch, fixing regressions discovered with x264_r

Re: [PATCH v10 02/16] target/riscv: fix clzw implementation to operate on arg1

2021-09-05 Thread Richard Henderson
On 9/4/21 10:35 PM, Philipp Tomsich wrote: The refactored gen_clzw() uses ret as its argument, instead of arg1. Fix it. Signed-off-by: Philipp Tomsich --- Changes in v10: - New patch, fixing regressions discovered with x264_r. Fixes: 60903915050 ("target/riscv: Add DisasExtend to gen_unary")

[PATCH v10 02/16] target/riscv: fix clzw implementation to operate on arg1

2021-09-04 Thread Philipp Tomsich
The refactored gen_clzw() uses ret as its argument, instead of arg1. Fix it. Signed-off-by: Philipp Tomsich --- Changes in v10: - New patch, fixing regressions discovered with x264_r. target/riscv/insn_trans/trans_rvb.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ta