Re: [PATCH v1 4/4] x86-disas: add x86-mini disassembler implementation

2025-01-26 Thread Michael Clark
On 1/24/25 13:10, Michael Clark wrote: +static x86_opc_prefix x86_table_make_prefix(const x86_opc_data *d, +const x86_opr_data *o, const x86_ord_data *p) +{ +x86_opc_prefix tp; +memset(&tp, 0, sizeof(tp)); + +/* extract prefix and synthesize width prefixes */ +switch (x86_enc_

Re: [PATCH v1 4/4] x86-disas: add x86-mini disassembler implementation

2025-01-25 Thread Michael Clark
to save time on reviews. I had a look over the patch in light of QEMU conventions I neglected due to it being portable code. this is what I have found so far: - use g_malloc/g_malloc0/g_free instead of malloc/calloc/free. - remove duplicate unused definition of ctz/clz/popcnt. - remove some magi