Re: [PATCH v1 3/4] migration: refactor ram_save_target_page functions

2024-12-05 Thread Peter Xu
On Wed, Nov 27, 2024 at 11:12:09AM -0300, Fabiano Rosas wrote: > Prasad Pandit writes: > > > On Wed, 27 Nov 2024 at 02:49, Fabiano Rosas wrote: > >> This patch should be just the actual refactoring on top of master, with > >> no mention to postcopy at all. > > > > * Okay. We'll have to ensure th

Re: [PATCH v1 3/4] migration: refactor ram_save_target_page functions

2024-12-02 Thread Prasad Pandit
Hello Fabiano, On Mon, 2 Dec 2024 at 19:42, Fabiano Rosas wrote: > > ...multifd_send/_recv_sync_main();<= do the 'flush' and > > 'sync' mean the same thing here? > > No, that patch is indeed inconsistent in the terminology, good point. > Well, flush and sync are not reserved terms, we can u

Re: [PATCH v1 3/4] migration: refactor ram_save_target_page functions

2024-12-02 Thread Prasad Pandit
Hello Fabiano, On Thu, 28 Nov 2024 at 18:50, Fabiano Rosas wrote: >>> We currently have a mess of conditionals to achieve the correct >>> combination of multifd local flushes, where we sync the local >>> (send/recv) multifd threads between themselves, and multifd remote >>> flushes, where we put

Re: [PATCH v1 3/4] migration: refactor ram_save_target_page functions

2024-11-28 Thread Fabiano Rosas
Prasad Pandit writes: > On Wed, 27 Nov 2024 at 19:42, Fabiano Rosas wrote: >> From e9110360eb0efddf6945f37c518e3cc38d12b600 Mon Sep 17 00:00:00 2001 >> From: Fabiano Rosas >> Date: Wed, 27 Nov 2024 11:03:04 -0300 >> Subject: [PATCH] migration: Rationalize multifd flushes from ram code >> >> We

Re: [PATCH v1 3/4] migration: refactor ram_save_target_page functions

2024-11-28 Thread Prasad Pandit
On Wed, 27 Nov 2024 at 17:49, Fabiano Rosas wrote: > > On Wed, 27 Nov 2024 at 02:49, Fabiano Rosas wrote: > >> This patch should be just the actual refactoring on top of master, with > >> no mention to postcopy at all. ... > It doesn't need to be a single patch submission, it could be a patch at

Re: [PATCH v1 3/4] migration: refactor ram_save_target_page functions

2024-11-28 Thread Prasad Pandit
On Wed, 27 Nov 2024 at 19:42, Fabiano Rosas wrote: > From e9110360eb0efddf6945f37c518e3cc38d12b600 Mon Sep 17 00:00:00 2001 > From: Fabiano Rosas > Date: Wed, 27 Nov 2024 11:03:04 -0300 > Subject: [PATCH] migration: Rationalize multifd flushes from ram code > > We currently have a mess of conditi

Re: [PATCH v1 3/4] migration: refactor ram_save_target_page functions

2024-11-27 Thread Fabiano Rosas
Prasad Pandit writes: > On Wed, 27 Nov 2024 at 02:49, Fabiano Rosas wrote: >> This patch should be just the actual refactoring on top of master, with >> no mention to postcopy at all. > > * Okay. We'll have to ensure that it is merged before multifd+postcopy change. > >> > +if (migra

Re: [PATCH v1 3/4] migration: refactor ram_save_target_page functions

2024-11-27 Thread Fabiano Rosas
Prasad Pandit writes: > On Wed, 27 Nov 2024 at 02:49, Fabiano Rosas wrote: >> This patch should be just the actual refactoring on top of master, with >> no mention to postcopy at all. > > * Okay. We'll have to ensure that it is merged before multifd+postcopy change. That's ok, just put it at th

Re: [PATCH v1 3/4] migration: refactor ram_save_target_page functions

2024-11-27 Thread Prasad Pandit
On Wed, 27 Nov 2024 at 02:49, Fabiano Rosas wrote: > This patch should be just the actual refactoring on top of master, with > no mention to postcopy at all. * Okay. We'll have to ensure that it is merged before multifd+postcopy change. > > +if (migrate_multifd() && !migration_in_pos

Re: [PATCH v1 3/4] migration: refactor ram_save_target_page functions

2024-11-26 Thread Fabiano Rosas
Prasad Pandit writes: > From: Prasad Pandit > > Refactor ram_save_target_page legacy and multifd > functions into one. Other than simplifying it, > it frees 'migration_ops' object from usage, so it > is expunged. > > When both Multifd and Postcopy modes are enabled, > to avoid errors, the Multif

[PATCH v1 3/4] migration: refactor ram_save_target_page functions

2024-11-26 Thread Prasad Pandit
From: Prasad Pandit Refactor ram_save_target_page legacy and multifd functions into one. Other than simplifying it, it frees 'migration_ops' object from usage, so it is expunged. When both Multifd and Postcopy modes are enabled, to avoid errors, the Multifd threads are active until migration rea