Re: [PATCH v1 12/15] libvhost-user: Use most of mmap_offset as fd_offset

2024-02-03 Thread Raphael Norwitz
On Fri, Feb 2, 2024 at 4:55 PM David Hildenbrand wrote: > > In the past, QEMU would create memory regions that could partially cover > hugetlb pages, making mmap() fail if we would use the mmap_offset as an > fd_offset. For that reason, we never used the mmap_offset as an offset into > the fd and

[PATCH v1 12/15] libvhost-user: Use most of mmap_offset as fd_offset

2024-02-02 Thread David Hildenbrand
In the past, QEMU would create memory regions that could partially cover hugetlb pages, making mmap() fail if we would use the mmap_offset as an fd_offset. For that reason, we never used the mmap_offset as an offset into the fd and instead always mapped the fd from the very start. However, that ca