Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-11 Thread Alex Bennée
Brice Goglin writes: > Le 10/04/2020 à 14:33, Alex Bennée a écrit : >> That was by inspection on my system which seems to truncate a lot >> earlier. It would be nice to find where in the Linux kernel it is >> output but I failed to grep the relevant function last night. > > > It's in proc/array

Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-10 Thread Richard Henderson
On 4/9/20 2:15 PM, Alex Bennée wrote: > In the original bug report long files names in Guix caused > /proc/self/stat be truncated without the trailing ") " as specified in > proc manpage which says: > (2) comm %s >The filename of the executable, in parentheses. This >

Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-10 Thread Brice Goglin
Le 10/04/2020 à 14:33, Alex Bennée a écrit : > That was by inspection on my system which seems to truncate a lot > earlier. It would be nice to find where in the Linux kernel it is > output but I failed to grep the relevant function last night. It's in proc/array.c, do_task_stat() calls proc_task

Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-10 Thread Philippe Mathieu-Daudé
On 4/10/20 2:33 PM, Alex Bennée wrote: That was by inspection on my system which seems to truncate a lot earlier. It would be nice to find where in the Linux kernel it is output but I failed to grep the relevant function last night. OK. Patch is correct with this value, so: Reviewed-by: Philip

Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-10 Thread Alex Bennée
That was by inspection on my system which seems to truncate a lot earlier. It would be nice to find where in the Linux kernel it is output but I failed to grep the relevant function last night. On Fri, 10 Apr 2020, 12:11 Philippe Mathieu-Daudé, wrote: > Cc'ing Ludovic in case he can test with Gu

Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-10 Thread Philippe Mathieu-Daudé
Cc'ing Ludovic in case he can test with Guix-HPC. On 4/9/20 11:15 PM, Alex Bennée wrote: In the original bug report long files names in Guix caused /proc/self/stat be truncated without the trailing ") " as specified in proc manpage which says: (2) comm %s The filename of the e

[PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-09 Thread Alex Bennée
In the original bug report long files names in Guix caused /proc/self/stat be truncated without the trailing ") " as specified in proc manpage which says: (2) comm %s The filename of the executable, in parentheses. This is visible whether or not the executable is swa