Re: [PATCH v1 1/6] hw/arm/xlnx-zynqmp: Add unimplemented SERDES area

2022-01-31 Thread Edgar E. Iglesias
On Mon, Jan 31, 2022 at 03:32:25PM +, Peter Maydell wrote: > On Sun, 30 Jan 2022 at 23:12, Edgar E. Iglesias > wrote: > > > > From: "Edgar E. Iglesias" > > > > Add unimplemented SERDES area. > > What's a SERDES ? A brief description might be helpful in > the commit message or a comment. The

Re: [PATCH v1 1/6] hw/arm/xlnx-zynqmp: Add unimplemented SERDES area

2022-01-31 Thread Francisco Iglesias
On Mon, Jan 31, 2022 at 12:12:01AM +0100, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add unimplemented SERDES area. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Francisco Iglesias > --- > include/hw/arm/xlnx-zynqmp.h | 2 +- > hw/arm/xlnx-zynqmp.c | 4 > 2 fi

Re: [PATCH v1 1/6] hw/arm/xlnx-zynqmp: Add unimplemented SERDES area

2022-01-31 Thread Peter Maydell
On Sun, 30 Jan 2022 at 23:12, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Add unimplemented SERDES area. What's a SERDES ? A brief description might be helpful in the commit message or a comment. thanks -- PMM

Re: [PATCH v1 1/6] hw/arm/xlnx-zynqmp: Add unimplemented SERDES area

2022-01-30 Thread Philippe Mathieu-Daudé via
On 31/1/22 00:12, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Add unimplemented SERDES area. Signed-off-by: Edgar E. Iglesias --- include/hw/arm/xlnx-zynqmp.h | 2 +- hw/arm/xlnx-zynqmp.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Philippe Math

[PATCH v1 1/6] hw/arm/xlnx-zynqmp: Add unimplemented SERDES area

2022-01-30 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add unimplemented SERDES area. Signed-off-by: Edgar E. Iglesias --- include/hw/arm/xlnx-zynqmp.h | 2 +- hw/arm/xlnx-zynqmp.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h in