> > +
> > +g_assert(qemu_logfile_mutex.initialized);
>
> Why the asserts?
>
> If you want a runtime test, then use the test to initialize it.
> Otherwise, trust the constructor.
>
I see your point here. We can/should just trust the constructor.
Will remove the mutex.initialized asserts.
Than
On 11/12/19 4:01 PM, Robert Foley wrote:
> Also added qemu_logfile_init() for initializing the logfile mutex.
>
> Signed-off-by: Robert Foley
> ---
> v1
> - changed qemu_logfile_init() to use __constructor__.
> ---
> util/log.c | 14 ++
> 1 file changed, 14 insertions(+)
>
> dif
Robert Foley writes:
> Also added qemu_logfile_init() for initializing the logfile mutex.
>
> Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
> ---
> v1
> - changed qemu_logfile_init() to use __constructor__.
> ---
> util/log.c | 14 ++
> 1 file changed, 14 insertions(
Also added qemu_logfile_init() for initializing the logfile mutex.
Signed-off-by: Robert Foley
---
v1
- changed qemu_logfile_init() to use __constructor__.
---
util/log.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/util/log.c b/util/log.c
index 1ca13059ee..c25643dc99