Re: [PATCH v1 1/1] riscv/boot: Fix possible memory leak

2019-10-03 Thread Peter Maydell
On Thu, 3 Oct 2019 at 01:53, Bin Meng wrote: > > On Thu, Oct 3, 2019 at 5:38 AM Alistair Francis > wrote: > > > > Coverity (CID 1405786) thinks that there is a possible memory leak as > > we don't guarentee that the memory allocatd from riscv_find_firmware() > > is freed. This is a false positive

Re: [PATCH v1 1/1] riscv/boot: Fix possible memory leak

2019-10-03 Thread Philippe Mathieu-Daudé
On 10/2/19 11:34 PM, Alistair Francis wrote: Coverity (CID 1405786) thinks that there is a possible memory leak as we don't guarentee that the memory allocatd from riscv_find_firmware() typos: 'guarantee', 'allocated' is freed. This is a false positive, but let's tidy up the code to fix the w

Re: [PATCH v1 1/1] riscv/boot: Fix possible memory leak

2019-10-02 Thread Bin Meng
On Thu, Oct 3, 2019 at 5:38 AM Alistair Francis wrote: > > Coverity (CID 1405786) thinks that there is a possible memory leak as > we don't guarentee that the memory allocatd from riscv_find_firmware() > is freed. This is a false positive, but let's tidy up the code to fix > the warning. > > Signe

Re: [PATCH v1 1/1] riscv/boot: Fix possible memory leak

2019-10-02 Thread Richard Henderson
On 10/2/19 2:34 PM, Alistair Francis wrote: > Coverity (CID 1405786) thinks that there is a possible memory leak as > we don't guarentee that the memory allocatd from riscv_find_firmware() > is freed. This is a false positive, but let's tidy up the code to fix > the warning. > > Signed-off-by: Ali

[PATCH v1 1/1] riscv/boot: Fix possible memory leak

2019-10-02 Thread Alistair Francis
Coverity (CID 1405786) thinks that there is a possible memory leak as we don't guarentee that the memory allocatd from riscv_find_firmware() is freed. This is a false positive, but let's tidy up the code to fix the warning. Signed-off-by: Alistair Francis --- hw/riscv/boot.c | 11 --- 1