Re: [PATCH v1 1/1] hw/riscv/boot: Check the error of fdt_pack()

2021-07-14 Thread Alistair Francis
On Wed, Jul 14, 2021 at 6:46 PM Peter Maydell wrote: > > On Wed, 14 Jul 2021 at 08:22, Alistair Francis > wrote: > > > > Coverity reports that we don't check the error result of fdt_pack(), so > > let's save the result and assert that it is 0. > > > > Fixes: Coverity CID 1458136 > > Signed-off-b

Re: [PATCH v1 1/1] hw/riscv/boot: Check the error of fdt_pack()

2021-07-14 Thread Peter Maydell
On Wed, 14 Jul 2021 at 08:22, Alistair Francis wrote: > > Coverity reports that we don't check the error result of fdt_pack(), so > let's save the result and assert that it is 0. > > Fixes: Coverity CID 1458136 > Signed-off-by: Alistair Francis > --- > hw/riscv/boot.c | 5 +++-- > 1 file changed

Re: [PATCH v1 1/1] hw/riscv/boot: Check the error of fdt_pack()

2021-07-14 Thread Bin Meng
On Wed, Jul 14, 2021 at 3:22 PM Alistair Francis wrote: > > Coverity reports that we don't check the error result of fdt_pack(), so > let's save the result and assert that it is 0. > > Fixes: Coverity CID 1458136 > Signed-off-by: Alistair Francis > --- > hw/riscv/boot.c | 5 +++-- > 1 file chang

[PATCH v1 1/1] hw/riscv/boot: Check the error of fdt_pack()

2021-07-14 Thread Alistair Francis
Coverity reports that we don't check the error result of fdt_pack(), so let's save the result and assert that it is 0. Fixes: Coverity CID 1458136 Signed-off-by: Alistair Francis --- hw/riscv/boot.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/riscv/boot.c b/hw/ris