Re: [PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-14 Thread Stefano Garzarella
On Sat, Apr 11, 2020 at 01:58:07PM +0100, Alex Bennée wrote: > > Stefano Garzarella writes: > > > On Thu, Apr 09, 2020 at 10:15:27PM +0100, Alex Bennée wrote: > >> From: Peter Xu > >> > >> We should only pass in gdb_get_reg16() with the GByteArray* object > >> itself, no need to shift. Withou

Re: [PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-11 Thread Philippe Mathieu-Daudé
On 4/10/20 3:08 PM, Stefano Garzarella wrote: On Thu, Apr 09, 2020 at 10:15:27PM +0100, Alex Bennée wrote: From: Peter Xu We should only pass in gdb_get_reg16() with the GByteArray* object itself, no need to shift. Without this patch, gdb remote attach will crash QEMU. Fixes: a010bdbe719 ("e

Re: [PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-11 Thread Alex Bennée
Stefano Garzarella writes: > On Thu, Apr 09, 2020 at 10:15:27PM +0100, Alex Bennée wrote: >> From: Peter Xu >> >> We should only pass in gdb_get_reg16() with the GByteArray* object >> itself, no need to shift. Without this patch, gdb remote attach will >> crash QEMU. >> >> Fixes: a010bdbe71

Re: [PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-10 Thread Richard Henderson
On 4/9/20 2:15 PM, Alex Bennée wrote: > From: Peter Xu > > We should only pass in gdb_get_reg16() with the GByteArray* object > itself, no need to shift. Without this patch, gdb remote attach will > crash QEMU. > > Fixes: a010bdbe719 ("extend GByteArray to read register helpers") > Signed-off-b

Re: [PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-10 Thread Stefano Garzarella
On Thu, Apr 09, 2020 at 10:15:27PM +0100, Alex Bennée wrote: > From: Peter Xu > > We should only pass in gdb_get_reg16() with the GByteArray* object > itself, no need to shift. Without this patch, gdb remote attach will > crash QEMU. > > Fixes: a010bdbe719 ("extend GByteArray to read register h

[PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-09 Thread Alex Bennée
From: Peter Xu We should only pass in gdb_get_reg16() with the GByteArray* object itself, no need to shift. Without this patch, gdb remote attach will crash QEMU. Fixes: a010bdbe719 ("extend GByteArray to read register helpers") Signed-off-by: Peter Xu Reviewed-by: Philippe Mathieu-Daudé Sign