Re: [PATCH v1 05/59] ram.c: remove unneeded labels

2020-01-08 Thread Juan Quintela
Daniel Henrique Barboza wrote: > ram_save_queue_pages() has an 'err' label that can be replaced by > 'return -1' instead. > > Same thing with ram_discard_range(), and in this case we can also > get rid of the 'ret' variable and return either '-1' on error > or the result of ram_block_discard_range

Re: [PATCH v1 05/59] ram.c: remove unneeded labels

2020-01-06 Thread Juan Quintela
Daniel Henrique Barboza wrote: > ram_save_queue_pages() has an 'err' label that can be replaced by > 'return -1' instead. > > Same thing with ram_discard_range(), and in this case we can also > get rid of the 'ret' variable and return either '-1' on error > or the result of ram_block_discard_range

Re: [PATCH v1 05/59] ram.c: remove unneeded labels

2020-01-06 Thread Dr. David Alan Gilbert
* Daniel Henrique Barboza (danielhb...@gmail.com) wrote: > ram_save_queue_pages() has an 'err' label that can be replaced by > 'return -1' instead. > > Same thing with ram_discard_range(), and in this case we can also > get rid of the 'ret' variable and return either '-1' on error > or the result

[PATCH v1 05/59] ram.c: remove unneeded labels

2020-01-06 Thread Daniel Henrique Barboza
ram_save_queue_pages() has an 'err' label that can be replaced by 'return -1' instead. Same thing with ram_discard_range(), and in this case we can also get rid of the 'ret' variable and return either '-1' on error or the result of ram_block_discard_range(). CC: Juan Quintela CC: Dr. David Alan