Re: [PATCH v1 04/15] libvhost-user: Factor out removing all mem regions

2024-02-03 Thread Raphael Norwitz
On Fri, Feb 2, 2024 at 4:54 PM David Hildenbrand wrote: > > Let's factor it out. Note that the check for MAP_FAILED was wrong as > we never set mmap_addr if mmap() failed. We'll remove the NULL check > separately. > > Signed-off-by: David Hildenbrand Reviewed-by: Raphael Norwitz > --- > subpr

[PATCH v1 04/15] libvhost-user: Factor out removing all mem regions

2024-02-02 Thread David Hildenbrand
Let's factor it out. Note that the check for MAP_FAILED was wrong as we never set mmap_addr if mmap() failed. We'll remove the NULL check separately. Signed-off-by: David Hildenbrand --- subprojects/libvhost-user/libvhost-user.c | 34 --- 1 file changed, 18 insertions(+), 16