Re: [PATCH v1 03/16] qapi: fix example of query-spice command

2022-09-01 Thread Gerd Hoffmann
Hi, > I agree listing more channels in the example wouldn't help users. > > But do we want to indicate that the example is abridged? Hard to do if the result should be valid qmp ... Maybe add a second channel to clearly show the command returns a list of channels? I'm also curious why you ch

Re: [PATCH v1 03/16] qapi: fix example of query-spice command

2022-08-31 Thread Markus Armbruster
Victor Toso writes: > Hi, > > On Wed, Aug 31, 2022 at 01:50:31PM +0200, Markus Armbruster wrote: >> Victor Toso writes: >> >> > Example output has an extra ',' delimiter and a foreign comment >> > format. Fix it. >> > >> > Problem was noticed when trying to load the example into python's json >>

Re: [PATCH v1 03/16] qapi: fix example of query-spice command

2022-08-31 Thread Victor Toso
Hi, On Wed, Aug 31, 2022 at 01:50:31PM +0200, Markus Armbruster wrote: > Victor Toso writes: > > > Example output has an extra ',' delimiter and a foreign comment > > format. Fix it. > > > > Problem was noticed when trying to load the example into python's json > > library. > > > > Signed-off-by:

Re: [PATCH v1 03/16] qapi: fix example of query-spice command

2022-08-31 Thread Markus Armbruster
Victor Toso writes: > Example output has an extra ',' delimiter and a foreign comment > format. Fix it. > > Problem was noticed when trying to load the example into python's json > library. > > Signed-off-by: Victor Toso > --- > qapi/ui.json | 3 +-- > 1 file changed, 1 insertion(+), 2 deletion

[PATCH v1 03/16] qapi: fix example of query-spice command

2022-08-30 Thread Victor Toso
Example output has an extra ',' delimiter and a foreign comment format. Fix it. Problem was noticed when trying to load the example into python's json library. Signed-off-by: Victor Toso --- qapi/ui.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/qapi/ui.json b/qapi/u