Re: [PATCH v1 0/7] Validate and test qapi examples

2023-09-14 Thread Victor Toso
Hi, On Fri, Sep 08, 2023 at 09:51:35AM +0200, Philippe Mathieu-Daudé wrote: > On 7/9/23 20:17, Victor Toso wrote: > > Hi, > > > >File "/home/berrange/src/virt/qemu/scripts/qapi/dumpexamples.py", line > > > 118, in parse_examples_of > > > assert((obj.doc is not None)) > > >

Re: [PATCH v1 0/7] Validate and test qapi examples

2023-09-08 Thread Daniel P . Berrangé
On Fri, Sep 08, 2023 at 09:51:35AM +0200, Philippe Mathieu-Daudé wrote: > On 7/9/23 20:17, Victor Toso wrote: > > Hi, > > > >File "/home/berrange/src/virt/qemu/scripts/qapi/dumpexamples.py", line > > > 118, in parse_examples_of > > > assert((obj.doc is not None)) > > > ^

Re: [PATCH v1 0/7] Validate and test qapi examples

2023-09-08 Thread Philippe Mathieu-Daudé
On 7/9/23 20:17, Victor Toso wrote: Hi, File "/home/berrange/src/virt/qemu/scripts/qapi/dumpexamples.py", line 118, in parse_examples_of assert((obj.doc is not None)) ^^^ AssertionError ninja: build stopped: subcommand failed. not sure if that's related t

Re: [PATCH v1 0/7] Validate and test qapi examples

2023-09-07 Thread Victor Toso
Hi, Thanks for the quick review Daniel! On Wed, Sep 06, 2023 at 10:17:04AM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 05, 2023 at 09:48:39PM +0200, Victor Toso wrote: > > Hi, > > > > This is a follow up from the RFC sent in the end of 08-2022: > > https://lists.gnu.org/archive/html/qemu-

Re: [PATCH v1 0/7] Validate and test qapi examples

2023-09-06 Thread Daniel P . Berrangé
On Tue, Sep 05, 2023 at 09:48:39PM +0200, Victor Toso wrote: > Hi, > > This is a follow up from the RFC sent in the end of 08-2022: > https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg04525.html > > The generator code was rebased, without conflicts. The commit log was > improved as per

[PATCH v1 0/7] Validate and test qapi examples

2023-09-05 Thread Victor Toso
Hi, This is a follow up from the RFC sent in the end of 08-2022: https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg04525.html The generator code was rebased, without conflicts. The commit log was improved as per Markus suggestion [0], altough I'm sure it can be improved further. To cl