Re: [PATCH v1] memory: remove assert to avoid unnecessary coredump

2020-03-02 Thread Yan Zhao
On Tue, Mar 03, 2020 at 01:22:26PM +0800, Yi Sun wrote: > On 20-03-02 22:36:39, Yan Zhao wrote: > > On Tue, Mar 03, 2020 at 11:11:14AM +0800, Yi Sun wrote: > > > It is too strict to use assert to make qemu coredump if > > > the notification does not overlap with registered range. > > > Skip it is f

Re: [PATCH v1] memory: remove assert to avoid unnecessary coredump

2020-03-02 Thread Yi Sun
On 20-03-02 22:36:39, Yan Zhao wrote: > On Tue, Mar 03, 2020 at 11:11:14AM +0800, Yi Sun wrote: > > It is too strict to use assert to make qemu coredump if > > the notification does not overlap with registered range. > > Skip it is fine enough. > > > > During test, we found such a case for vhost n

Re: [PATCH v1] memory: remove assert to avoid unnecessary coredump

2020-03-02 Thread Yan Zhao
On Tue, Mar 03, 2020 at 11:11:14AM +0800, Yi Sun wrote: > It is too strict to use assert to make qemu coredump if > the notification does not overlap with registered range. > Skip it is fine enough. > > During test, we found such a case for vhost net device: > memory_region_notify_one: entry->

[PATCH v1] memory: remove assert to avoid unnecessary coredump

2020-03-02 Thread Yi Sun
It is too strict to use assert to make qemu coredump if the notification does not overlap with registered range. Skip it is fine enough. During test, we found such a case for vhost net device: memory_region_notify_one: entry->iova=0xfee0, entry_end=0xfeff, notifier->start=0xfef0,