Re: [PATCH v1] chardev/char-socket: fix double free of err after socket is disconnected

2020-06-24 Thread Derek Su
Oops! Sorry, I dont’t notice this patch before. Thanks. Derek Philippe Mathieu-Daudé 於 2020年6月24日 週三,下午6:12寫道: > On 6/24/20 12:00 PM, Derek Su wrote: > > The err is freed in check_report_connect_error() conditionally, > > calling error_free() directly may lead to a double-free bug. > > This see

Re: [PATCH v1] chardev/char-socket: fix double free of err after socket is disconnected

2020-06-24 Thread Philippe Mathieu-Daudé
On 6/24/20 12:00 PM, Derek Su wrote: > The err is freed in check_report_connect_error() conditionally, > calling error_free() directly may lead to a double-free bug. This seems the same issue Lichun is working on, right? https://www.mail-archive.com/qemu-devel@nongnu.org/msg714709.html > > Signe

[PATCH v1] chardev/char-socket: fix double free of err after socket is disconnected

2020-06-24 Thread Derek Su
The err is freed in check_report_connect_error() conditionally, calling error_free() directly may lead to a double-free bug. Signed-off-by: Derek Su --- chardev/char-socket.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c in