Re: [PATCH v1] Adding new machine Yosemitev2 in QEMU

Ok, will do that. On Tue, Feb 14, 2023 at 12:35 PM Cédric Le Goater wrote: > Hello, > > [ adding the lists ] > > > > +static void fb_bmc_i2c_init(AspeedMachineState *bmc) > > > > The same routine name is proposed in the tiogapass patch : > > > > > https://lore.kernel.org/qemu-devel/2023

Re: [PATCH v1] Adding new machine Yosemitev2 in QEMU

Hello, [ adding the lists ] > +static void fb_bmc_i2c_init(AspeedMachineState *bmc) The same routine name is proposed in the tiogapass patch : https://lore.kernel.org/qemu-devel/20230210122641.837614-1-pkarthikeyan1...@gmail.com/

Re: [PATCH v1] Adding new machine Yosemitev2 in QEMU

Hello, On 2/10/23 13:50, Karthikeyan Pasupathi wrote: This patch support Yosemitev2 in QEMU environment. It looks OK apart from the naming. Could we call it "yosemite2-bmc" instead ? Thanks, C. Signed-off-by: Karthikeyan Pasupathi --- hw/arm/aspeed.c | 30 ++

[PATCH v1] Adding new machine Yosemitev2 in QEMU

This patch support Yosemitev2 in QEMU environment. Signed-off-by: Karthikeyan Pasupathi --- hw/arm/aspeed.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 27dda58338..74dc07190d 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm