Re: [PATCH ssh] ssh: Do not switch session to non-blocking mode

2024-11-25 Thread Jakub Jelen
On Fri, Nov 22, 2024 at 3:43 PM Kevin Wolf wrote: > > So going back to the original issue, is the proposed patch something > > that could work for you in the short term before a better solution > > will be implemented or is there something we should change? > > Given that apparently it was always

Re: [PATCH ssh] ssh: Do not switch session to non-blocking mode

2024-11-22 Thread Kevin Wolf
Am 18.11.2024 um 18:06 hat Jakub Jelen geschrieben: > Hi Kevin, > Sorry for the delay, my gmail filters will need some love to handle this > high-traffic mailing lists so I can catch replies ... > > On Thu, Nov 14, 2024 at 6:49 PM Kevin Wolf wrote: > > [...] > > Hm, after looking some more at the

Re: [PATCH ssh] ssh: Do not switch session to non-blocking mode

2024-11-18 Thread Jakub Jelen
Hi Kevin, Sorry for the delay, my gmail filters will need some love to handle this high-traffic mailing lists so I can catch replies ... On Thu, Nov 14, 2024 at 6:49 PM Kevin Wolf wrote: > [...] > Hm, after looking some more at the code, I agree that it can't have > worked, for the simple reason

Re: [PATCH ssh] ssh: Do not switch session to non-blocking mode

2024-11-14 Thread Kevin Wolf
Am 14.11.2024 um 17:49 hat Jakub Jelen geschrieben: > Hello, > comments inline below. > > On Thu, Nov 14, 2024 at 4:21 PM Kevin Wolf wrote: > > [...] > > > > > I'll just note that I'm only forwarding on the patch from Jakub. > > > I didn't write it. > > > > > > I did lightly test it, and it seems

Re: [PATCH ssh] ssh: Do not switch session to non-blocking mode

2024-11-14 Thread Jakub Jelen
Hello, comments inline below. On Thu, Nov 14, 2024 at 4:21 PM Kevin Wolf wrote: > [...] > > > I'll just note that I'm only forwarding on the patch from Jakub. > > I didn't write it. > > > > I did lightly test it, and it seems to work. However it seems also > > likely that it is causing qemu to b

Re: [PATCH ssh] ssh: Do not switch session to non-blocking mode

2024-11-14 Thread Kevin Wolf
Am 13.11.2024 um 14:00 hat Richard W.M. Jones geschrieben: > On Wed, Nov 13, 2024 at 03:02:59PM +0300, Michael Tokarev wrote: > > Heh. I was creating a qemu bug report on gitlab when this email arrived :) > > > > 13.11.2024 14:49, Richard W.M. Jones wrote: > > >From: Jakub Jelen > > > > > >The li

Re: [PATCH ssh] ssh: Do not switch session to non-blocking mode

2024-11-13 Thread Richard W.M. Jones
On Wed, Nov 13, 2024 at 03:02:59PM +0300, Michael Tokarev wrote: > Heh. I was creating a qemu bug report on gitlab when this email arrived :) > > 13.11.2024 14:49, Richard W.M. Jones wrote: > >From: Jakub Jelen > > > >The libssh does not handle non-blocking mode in SFTP correctly. The > >driver c

Re: [PATCH ssh] ssh: Do not switch session to non-blocking mode

2024-11-13 Thread Michael Tokarev
Heh. I was creating a qemu bug report on gitlab when this email arrived :) 13.11.2024 14:49, Richard W.M. Jones wrote: From: Jakub Jelen The libssh does not handle non-blocking mode in SFTP correctly. The driver code already changes the mode to blocking for the SFTP initialization, but for som

[PATCH ssh] ssh: Do not switch session to non-blocking mode

2024-11-13 Thread Richard W.M. Jones
From: Jakub Jelen The libssh does not handle non-blocking mode in SFTP correctly. The driver code already changes the mode to blocking for the SFTP initialization, but for some reason changes to non-blocking mode. This used to work accidentally until libssh in 0.11 branch merged the patch to avoi