Peter,
Hi; Coverity has just noticed an issue with this patch:
[...]
Here we declare the is_oneshot variable...
[...]
...but here we declare another is_oneshot, which shadows the first
declaration...
...so here when the inner variable is no longer in scope, the
value of the outer is_oneshot vari
On Thu, 1 Dec 2022 at 15:42, ~axelheider wrote:
>
> From: Axel Heider
>
> - fix #1263 for CR writes
> - rework compare time handling
> - The compare timer has to run even if CR.OCIEN is not set,
> as SR.OCIF must be updated.
> - The compare timer fires exactly once when the
> compare
Peter,
There's a couple of minor code-style issues here (block comment
format, variable declarations in the middle of a block); rather
than asking you to re-roll the series I'll just squash in the
fixes for those:
[...]
Thanks, that makes things easier. Seems these still unfortunately
slipped
On Thu, 1 Dec 2022 at 15:42, ~axelheider wrote:
>
> From: Axel Heider
>
> - fix #1263 for CR writes
> - rework compare time handling
> - The compare timer has to run even if CR.OCIEN is not set,
> as SR.OCIF must be updated.
> - The compare timer fires exactly once when the
> compare
From: Axel Heider
- fix #1263 for CR writes
- rework compare time handling
- The compare timer has to run even if CR.OCIEN is not set,
as SR.OCIF must be updated.
- The compare timer fires exactly once when the
compare value is less than the current value, but the
reload values is
