Re: [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes

On Mon, Sep 26, 2022 at 11:42:37PM +0200, Jason A. Donenfeld wrote: > On Mon, Sep 26, 2022 at 11:42 PM Laurent Vivier wrote: > > > > Le 26/09/2022 à 23:40, Jason A. Donenfeld a écrit : > > > On Mon, Sep 26, 2022 at 11:37 PM Laurent Vivier wrote: > > >> > > >> Le 26/09/2022 à 13:39, Jason A. Donen

Re: [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes

Le 26/09/2022 à 23:40, Jason A. Donenfeld a écrit : On Mon, Sep 26, 2022 at 11:37 PM Laurent Vivier wrote: Le 26/09/2022 à 13:39, Jason A. Donenfeld a écrit : Various tools, such as kexec-tools and m68k-bootinfo, expect each bootinfo entry to be aligned to 4 bytes, not 2 bytes. So adjust the

Re: [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes

On Mon, Sep 26, 2022 at 11:42 PM Laurent Vivier wrote: > > Le 26/09/2022 à 23:40, Jason A. Donenfeld a écrit : > > On Mon, Sep 26, 2022 at 11:37 PM Laurent Vivier wrote: > >> > >> Le 26/09/2022 à 13:39, Jason A. Donenfeld a écrit : > >>> Various tools, such as kexec-tools and m68k-bootinfo, expec

Re: [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes

On Mon, Sep 26, 2022 at 11:37 PM Laurent Vivier wrote: > > Le 26/09/2022 à 13:39, Jason A. Donenfeld a écrit : > > Various tools, such as kexec-tools and m68k-bootinfo, expect each > > bootinfo entry to be aligned to 4 bytes, not 2 bytes. So adjust the > > padding to fill this out as such. > > > >

Re: [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes

Le 26/09/2022 à 13:39, Jason A. Donenfeld a écrit : Various tools, such as kexec-tools and m68k-bootinfo, expect each bootinfo entry to be aligned to 4 bytes, not 2 bytes. So adjust the padding to fill this out as such. Also, break apart the padding additions from the other field length addition

Re: [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes

Le 26/09/2022 à 13:39, Jason A. Donenfeld a écrit : Various tools, such as kexec-tools and m68k-bootinfo, expect each bootinfo entry to be aligned to 4 bytes, not 2 bytes. So adjust the padding to fill this out as such. Agree, I found the same problem using petitboot as a ROM for the virt machi

[PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes

Various tools, such as kexec-tools and m68k-bootinfo, expect each bootinfo entry to be aligned to 4 bytes, not 2 bytes. So adjust the padding to fill this out as such. Also, break apart the padding additions from the other field length additions, so that it's more clear why these magic numbers are