On Wed, Apr 24, 2024 at 01:13:01PM +0200, Paolo Bonzini wrote:
> Date: Wed, 24 Apr 2024 13:13:01 +0200
> From: Paolo Bonzini
> Subject: Re: [PATCH for-9.1 09/19] target/i386: move 60-BF opcodes to new
> decoder
>
> On Thu, Apr 11, 2024 at 5:05 PM Zhao Liu wrote:
> &g
On Thu, Apr 11, 2024 at 5:05 PM Zhao Liu wrote:
> HMM, I met Guest boot failure on this patch because of ata unrecognized.
> I haven't located the exact error yet, so let me post my log first.
> If there are other means I can use to dig further, I'd be happy to try
> that too.
>
> # Command (boot
On Thu, Apr 11, 2024 at 5:05 PM Zhao Liu wrote:
>
> On Tue, Apr 09, 2024 at 06:43:13PM +0200, Paolo Bonzini wrote:
> > Date: Tue, 9 Apr 2024 18:43:13 +0200
> > From: Paolo Bonzini
> > Subject: [PATCH for-9.1 09/19] target/i386: move 60-BF opcodes to new
> > decode
On Tue, Apr 09, 2024 at 06:43:13PM +0200, Paolo Bonzini wrote:
> Date: Tue, 9 Apr 2024 18:43:13 +0200
> From: Paolo Bonzini
> Subject: [PATCH for-9.1 09/19] target/i386: move 60-BF opcodes to new
> decoder
> X-Mailer: git-send-email 2.44.0
>
> Compared to the old decoder,
Hi Paolo,
I just did some tests,
> +[0x98] = X86_OP_ENTRY1(CBW,0,v), /* rAX */
> +[0x99] = X86_OP_ENTRY3(CWD,2,v, 0,v, None, None), /* rDX, rAX */
> +[0x9A] = X86_OP_ENTRYrr(CALLF, I_unsigned,p, I_unsigned,w, chk(i64)),
X86_TYPE_I_unsigned is defined in patch 11, so the relat
On Thu, Apr 11, 2024 at 9:47 AM Richard Henderson
wrote:
> > +case MO_32:
> > +#ifdef TARGET_X86_64
> > +/*
> > + * This could also use the same algorithm as MO_16. It produces
> > fewer
> > + * TCG ops and better code if flags are needed, but it requires a
> > 64-bi
On 4/9/24 06:43, Paolo Bonzini wrote:
+static void gen_ARPL(DisasContext *s, CPUX86State *env, X86DecodedInsn *decode)
+{
+TCGLabel *label1 = gen_new_label();
+TCGv rpl_adj = tcg_temp_new();
+TCGv flags = tcg_temp_new();
+
+gen_mov_eflags(s, flags);
+tcg_gen_andi_tl(flags, fla
Compared to the old decoder, the main differences in translation
are for the little-used ARPL instruction. IMUL is adjusted a bit
to share more code to produce flags, but is otherwise very similar.
Signed-off-by: Paolo Bonzini
---
target/i386/tcg/decode-new.h | 2 +
target/i386/tcg/transl
