Re: [PATCH for-9.0] target/riscv/cpu.c: fix machine IDs getters

2023-12-17 Thread Alistair Francis
On Tue, Dec 12, 2023 at 3:08 AM Daniel Henrique Barboza wrote: > > mvendorid is an uint32 property, mimpid/marchid are uint64 properties. > But their getters are returning bools. The reason this went under the > radar for this long is because we have no code using the getters. > > The problem can

Re: [PATCH for-9.0] target/riscv/cpu.c: fix machine IDs getters

2023-12-17 Thread Alistair Francis
On Tue, Dec 12, 2023 at 3:08 AM Daniel Henrique Barboza wrote: > > mvendorid is an uint32 property, mimpid/marchid are uint64 properties. > But their getters are returning bools. The reason this went under the > radar for this long is because we have no code using the getters. > > The problem can

Re: [PATCH for-9.0] target/riscv/cpu.c: fix machine IDs getters

2023-12-11 Thread Philippe Mathieu-Daudé
On 11/12/23 18:07, Daniel Henrique Barboza wrote: mvendorid is an uint32 property, mimpid/marchid are uint64 properties. But their getters are returning bools. The reason this went under the radar for this long is because we have no code using the getters. The problem can be seem via the 'qom-ge

[PATCH for-9.0] target/riscv/cpu.c: fix machine IDs getters

2023-12-11 Thread Daniel Henrique Barboza
mvendorid is an uint32 property, mimpid/marchid are uint64 properties. But their getters are returning bools. The reason this went under the radar for this long is because we have no code using the getters. The problem can be seem via the 'qom-get' API though. Launching QEMU with the 'veyron-v1' C