Re: [PATCH for-8.2 0/4] rtc devices: Avoid putting time_t in 32-bit variables

2023-08-29 Thread Peter Maydell
On Thu, 20 Jul 2023 at 16:59, Peter Maydell wrote: > > This patchset was prompted by a couple of Coverity warnings > (CID 1507157, 1517772) which note that in the m48t59 RTC device model > we keep an offset in a time_t variable but then truncate it by > passing it to qemu_get_timedate(), which cur

Re: [PATCH for-8.2 0/4] rtc devices: Avoid putting time_t in 32-bit variables

2023-07-24 Thread Philippe Mathieu-Daudé
On 21/7/23 11:46, Peter Maydell wrote: On Fri, 21 Jul 2023 at 10:16, Philippe Mathieu-Daudé wrote: Hi Peter, On 20/7/23 17:58, Peter Maydell wrote: This patchset was prompted by a couple of Coverity warnings (CID 1507157, 1517772) which note that in the m48t59 RTC device model we keep an off

Re: [PATCH for-8.2 0/4] rtc devices: Avoid putting time_t in 32-bit variables

2023-07-23 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 21 Jul 2023 at 10:03, Philippe Mathieu-Daudé > wrote: >> >> +Markus >> >> On 20/7/23 17:58, Peter Maydell wrote: >> > This patchset was prompted by a couple of Coverity warnings >> > (CID 1507157, 1517772) which note that in the m48t59 RTC device model >> > we ke

Re: [PATCH for-8.2 0/4] rtc devices: Avoid putting time_t in 32-bit variables

2023-07-21 Thread Peter Maydell
On Fri, 21 Jul 2023 at 10:16, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 20/7/23 17:58, Peter Maydell wrote: > > This patchset was prompted by a couple of Coverity warnings > > (CID 1507157, 1517772) which note that in the m48t59 RTC device model > > we keep an offset in a time_t variable

Re: [PATCH for-8.2 0/4] rtc devices: Avoid putting time_t in 32-bit variables

2023-07-21 Thread Peter Maydell
On Fri, 21 Jul 2023 at 10:03, Philippe Mathieu-Daudé wrote: > > +Markus > > On 20/7/23 17:58, Peter Maydell wrote: > > This patchset was prompted by a couple of Coverity warnings > > (CID 1507157, 1517772) which note that in the m48t59 RTC device model > > we keep an offset in a time_t variable bu

Re: [PATCH for-8.2 0/4] rtc devices: Avoid putting time_t in 32-bit variables

2023-07-21 Thread Philippe Mathieu-Daudé
Hi Peter, On 20/7/23 17:58, Peter Maydell wrote: This patchset was prompted by a couple of Coverity warnings (CID 1507157, 1517772) which note that in the m48t59 RTC device model we keep an offset in a time_t variable but then truncate it by passing it to qemu_get_timedate(), which currently use

Re: [PATCH for-8.2 0/4] rtc devices: Avoid putting time_t in 32-bit variables

2023-07-21 Thread Philippe Mathieu-Daudé
+Markus On 20/7/23 17:58, Peter Maydell wrote: This patchset was prompted by a couple of Coverity warnings (CID 1507157, 1517772) which note that in the m48t59 RTC device model we keep an offset in a time_t variable but then truncate it by passing it to qemu_get_timedate(), which currently uses

[PATCH for-8.2 0/4] rtc devices: Avoid putting time_t in 32-bit variables

2023-07-20 Thread Peter Maydell
This patchset was prompted by a couple of Coverity warnings (CID 1507157, 1517772) which note that in the m48t59 RTC device model we keep an offset in a time_t variable but then truncate it by passing it to qemu_get_timedate(), which currently uses an 'int' argument for its offset parameter. We ca