Re: [PATCH for-8.1 05/17] target/riscv/cpu.c: add riscv_cpu_validate_priv_spec()

2023-03-08 Thread Richard Henderson
On 3/8/23 12:19, Daniel Henrique Barboza wrote: +static void riscv_cpu_validate_priv_spec(RISCVCPU *cpu, Error **errp) +{ +CPURISCVState *env = &cpu->env; +int i, priv_version = -1; + +if (cpu->cfg.priv_spec) { +if (!g_strcmp0(cpu->cfg.priv_spec, "v1.12.0")) { +pri

[PATCH for-8.1 05/17] target/riscv/cpu.c: add riscv_cpu_validate_priv_spec()

2023-03-08 Thread Daniel Henrique Barboza
Put all the env->priv_spec related validation into a helper to unclog riscv_cpu_realize a bit. Signed-off-by: Daniel Henrique Barboza --- target/riscv/cpu.c | 81 ++ 1 file changed, 46 insertions(+), 35 deletions(-) diff --git a/target/riscv/cpu.c b/t