Re: [PATCH for-8.1] target/m68k: Fix semihost lseek offset computation

2023-08-01 Thread Philippe Mathieu-Daudé
On 1/8/23 17:45, Peter Maydell wrote: The arguments for deposit64 are (value, start, length, fieldval); this appears to have thought they were (value, fieldval, start, length). Reorder the parameters to match the actual function. Cc: qemu-sta...@nongnu.org Fixes: 950272506d ("target/m68k: Use se

Re: [PATCH for-8.1] target/m68k: Fix semihost lseek offset computation

2023-08-01 Thread Philippe Mathieu-Daudé
On 1/8/23 17:45, Peter Maydell wrote: The arguments for deposit64 are (value, start, length, fieldval); this appears to have thought they were (value, fieldval, start, length). Reorder the parameters to match the actual function. Cc: qemu-sta...@nongnu.org Fixes: 950272506d ("target/m68k: Use se

[PATCH for-8.1] target/m68k: Fix semihost lseek offset computation

2023-08-01 Thread Peter Maydell
The arguments for deposit64 are (value, start, length, fieldval); this appears to have thought they were (value, fieldval, start, length). Reorder the parameters to match the actual function. Cc: qemu-sta...@nongnu.org Fixes: 950272506d ("target/m68k: Use semihosting/syscalls.h") Reported-by: Phil