On 3/28/23 11:27, Peter Maydell wrote:
On Tue, 28 Mar 2023 at 18:27, Richard Henderson
wrote:
On 3/28/23 09:28, Peter Maydell wrote:
+/*
+ * gen_exception_insn() will set is_jmp to DISAS_NORETURN,
+ * but since we're conditionally branching over it, we want
On 3/28/23 11:27, Peter Maydell wrote:
On Tue, 28 Mar 2023 at 18:27, Richard Henderson
wrote:
On 3/28/23 09:28, Peter Maydell wrote:
+/*
+ * gen_exception_insn() will set is_jmp to DISAS_NORETURN,
+ * but since we're conditionally branching over it, we want
On Tue, 28 Mar 2023 at 18:27, Richard Henderson
wrote:
>
> On 3/28/23 09:28, Peter Maydell wrote:
> > +/*
> > + * gen_exception_insn() will set is_jmp to DISAS_NORETURN,
> > + * but since we're conditionally branching over it, we want
> > + * to reta
On 3/28/23 09:28, Peter Maydell wrote:
+/*
+ * gen_exception_insn() will set is_jmp to DISAS_NORETURN,
+ * but since we're conditionally branching over it, we want
+ * to retain the existing value.
+ */
+old_is_jmp = s->base.
On 3/28/23 09:28, Peter Maydell wrote:
In commit 049edada we added some code to handle HSTR_EL2 traps, which
we did as an inline "conditionally branch over a
gen_exception_insn()". Unfortunately this fails to take account of
the fact that gen_exception_insn() will set s->base.is_jmp to
DISAS_NOR
In commit 049edada we added some code to handle HSTR_EL2 traps, which
we did as an inline "conditionally branch over a
gen_exception_insn()". Unfortunately this fails to take account of
the fact that gen_exception_insn() will set s->base.is_jmp to
DISAS_NORETURN. That means that at the end of the