Re: [PATCH for-7.0 0/4] qemu-common.h include cleanup

2021-12-01 Thread Philippe Mathieu-Daudé
On 11/29/21 21:05, Peter Maydell wrote: > Peter Maydell (4): > include/hw/i386: Don't include qemu-common.h in .h files > target/hexagon/cpu.h: don't include qemu-common.h > target/rx/cpu.h: Don't include qemu-common.h > hw/arm: Don't include qemu-common.h unnecessarily Reviewed-by: Phili

Re: [PATCH for-7.0 0/4] qemu-common.h include cleanup

2021-11-30 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 29 Nov 2021 at 20:05, Peter Maydell wrote: >> >> qemu-common.h has a comment at the top: >> >> * This file is supposed to be included only by .c files. No header file >> should >> * depend on qemu-common.h, as this would easily lead to circular header >> * dep

Re: [PATCH for-7.0 0/4] qemu-common.h include cleanup

2021-11-30 Thread Richard Henderson
On 11/29/21 9:05 PM, Peter Maydell wrote: qemu-common.h has a comment at the top: * This file is supposed to be included only by .c files. No header file should * depend on qemu-common.h, as this would easily lead to circular header * dependencies. We still have a few .h files which inclu

Re: [PATCH for-7.0 0/4] qemu-common.h include cleanup

2021-11-29 Thread Peter Maydell
On Mon, 29 Nov 2021 at 20:05, Peter Maydell wrote: > > qemu-common.h has a comment at the top: > > * This file is supposed to be included only by .c files. No header file > should > * depend on qemu-common.h, as this would easily lead to circular header > * dependencies. As a side note, that

[PATCH for-7.0 0/4] qemu-common.h include cleanup

2021-11-29 Thread Peter Maydell
qemu-common.h has a comment at the top: * This file is supposed to be included only by .c files. No header file should * depend on qemu-common.h, as this would easily lead to circular header * dependencies. We still have a few .h files which include it, though. The first 3 patches in this ser