Re: [PATCH for-6.2 5/7] linux-user: Provide new force_sig_fault() function

2021-08-16 Thread Richard Henderson
On 8/15/21 11:03 PM, Peter Maydell wrote: On Sun, 15 Aug 2021 at 21:10, Richard Henderson wrote: On 8/13/21 3:18 AM, Peter Maydell wrote: +void force_sig_fault(int sig, int code, abi_ulong addr) Better as abi_ptr? I followed the same type used for 'addr' in the target_siginfo_t struct def

Re: [PATCH for-6.2 5/7] linux-user: Provide new force_sig_fault() function

2021-08-16 Thread Peter Maydell
On Sun, 15 Aug 2021 at 21:10, Richard Henderson wrote: > > On 8/13/21 3:18 AM, Peter Maydell wrote: > > +void force_sig_fault(int sig, int code, abi_ulong addr) > > Better as abi_ptr? I followed the same type used for 'addr' in the target_siginfo_t struct definition. -- PMM

Re: [PATCH for-6.2 5/7] linux-user: Provide new force_sig_fault() function

2021-08-15 Thread Richard Henderson
On 8/13/21 3:18 AM, Peter Maydell wrote: +void force_sig_fault(int sig, int code, abi_ulong addr) Better as abi_ptr? Otherwise, Reviewed-by: Richard Henderson r~

[PATCH for-6.2 5/7] linux-user: Provide new force_sig_fault() function

2021-08-13 Thread Peter Maydell
In many places in the linux-user code we need to queue a signal for the guest using the QEMU_SI_FAULT si_type. This requires that the caller sets up and passes us a target_siginfo, including setting the appropriate part of the _sifields union for the si_type. In a number of places the code forgets