Re: [PATCH for-6.1 3/4] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code

2021-04-15 Thread Thomas Huth
On 15/04/2021 09.44, Markus Armbruster wrote: Thomas Huth writes: On 14/04/2021 15.55, Markus Armbruster wrote: Thomas Huth writes: The ObjectType enum and ObjectOptions are included from qapi-types-qom.h into common code. We should not use target-specific config switches like CONFIG_VIRTI

Re: [PATCH for-6.1 3/4] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code

2021-04-15 Thread Markus Armbruster
Thomas Huth writes: > On 14/04/2021 15.55, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> The ObjectType enum and ObjectOptions are included from qapi-types-qom.h >>> into common code. We should not use target-specific config switches like >>> CONFIG_VIRTIO_CRYPTO here, since this is no

Re: [PATCH for-6.1 3/4] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code

2021-04-14 Thread Thomas Huth
On 14/04/2021 15.55, Markus Armbruster wrote: Thomas Huth writes: The ObjectType enum and ObjectOptions are included from qapi-types-qom.h into common code. We should not use target-specific config switches like CONFIG_VIRTIO_CRYPTO here, since this is not defined in common code and thus the e

Re: [PATCH for-6.1 3/4] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code

2021-04-14 Thread Markus Armbruster
Thomas Huth writes: > The ObjectType enum and ObjectOptions are included from qapi-types-qom.h > into common code. We should not use target-specific config switches like > CONFIG_VIRTIO_CRYPTO here, since this is not defined in common code and > thus the enum will look differently between common

[PATCH for-6.1 3/4] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code

2021-04-14 Thread Thomas Huth
The ObjectType enum and ObjectOptions are included from qapi-types-qom.h into common code. We should not use target-specific config switches like CONFIG_VIRTIO_CRYPTO here, since this is not defined in common code and thus the enum will look differently between common and target specific code. For