Re: [PATCH for-6.0] x86:acpi:piix4: reinitialize PM1.CNT on reset

2021-03-17 Thread Reinoud Zandijk
Reported-by: Reinoud Zandijk Tested-by: Reinoud Zandijk It works fine now with the patch

Re: [PATCH for-6.0] x86:acpi:piix4: reinitialize PM1.CNT on reset

2021-03-17 Thread Igor Mammedov
On Tue, 16 Mar 2021 13:56:03 -0700 Isaku Yamahata wrote: > The fix itself looks good to me for the reported issue. > Should more registers be reset in theory? > But it would cause other issues. > > i.e. > acpi_pm1_evt_reset(&s->ar); > acpi_pm_tmr_reset(&s->ar); > acpi_gpe_reset(&s->ar); It's ve

Re: [PATCH for-6.0] x86:acpi:piix4: reinitialize PM1.CNT on reset

2021-03-16 Thread Isaku Yamahata
The fix itself looks good to me for the reported issue. Should more registers be reset in theory? But it would cause other issues. i.e. acpi_pm1_evt_reset(&s->ar); acpi_pm_tmr_reset(&s->ar); acpi_gpe_reset(&s->ar); Reviewed-by: Isaku Yamahata Thanks, On Tue, Mar 16, 2021 at 04:29:56PM -0400,

[PATCH for-6.0] x86:acpi:piix4: reinitialize PM1.CNT on reset

2021-03-16 Thread Igor Mammedov
Commit 6be8cf56bc8b made sure that SCI is enabled in PM1.CNT on reset in acpi_only mode by modifying acpi_pm1_cnt_reset() and that worked for q35 as expected. The function was introduced by commit eaba51c573a (acpi, acpi_piix, vt82c686: factor out PM1_CNT logic) that forgot to actually call it a